fix(vertex_ai): Handle missing tokenCount in promptTokensDetails #11581
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR is a Solution to the Error converting to a valid response block='tokenCount'. File an issue if litellm error - https://github.com/BerriAI/litellm/issues It's happening because vertex_ai is not sometimes sending the token count for the audio modality.
|
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ishaan-jaff
requested changes
Jun 10, 2025
| @@ -967,17 +967,17 @@ def _calculate_usage( | |||
| response_tokens_details = CompletionTokensDetailsWrapper() | |||
| for detail in usage_metadata["responseTokensDetails"]: | |||
| if detail["modality"] == "TEXT": | |||
| response_tokens_details.text_tokens = detail["tokenCount"] | |||
| response_tokens_details.text_tokens = detail.get("tokenCount", 0) | |||
There was a problem hiding this comment.
can you please add a unit test for this in tests_litellm/ @KingNish24
|
I will add the test |
ishaan-jaff
changed the base branch from
main
to
litellm_fix_missing_token_count_vertex
ishaan-jaff
merged commit cd028de
into
BerriAI:litellm_fix_missing_token_count_vertex
5 of 6 checks passed
ishaan-jaff
added a commit
that referenced
this pull request
Jun 19, 2025
#11896) * fix(vertex_ai): Handle missing tokenCount in promptTokensDetails (#11581) This PR is a Solution to the Error converting to a valid response block='tokenCount'. File an issue if litellm error - https://github.com/BerriAI/litellm/issues It's happening because vertex_ai is not sometimes sending the token count for the audio modality. * test_vertex_ai_usage_metadata_missing_token_count --------- Co-authored-by: Nishith Jain <167524748+KingNish24@users.noreply.github.com>
satendrakumar
pushed a commit
to satendrakumar/litellm
that referenced
this pull request
Jul 24, 2025
…riAI#11… (BerriAI#11896) * fix(vertex_ai): Handle missing tokenCount in promptTokensDetails (BerriAI#11581) This PR is a Solution to the Error converting to a valid response block='tokenCount'. File an issue if litellm error - https://github.com/BerriAI/litellm/issues It's happening because vertex_ai is not sometimes sending the token count for the audio modality. * test_vertex_ai_usage_metadata_missing_token_count --------- Co-authored-by: Nishith Jain <167524748+KingNish24@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
This PR is a Solution to the Error converting to a valid response block='tokenCount'. File an issue if litellm error - https://github.com/BerriAI/litellm/issues
It's happening because vertex_ai is not always sending the token count for the audio modality.
Relevant issues
Pre-Submission checklist
Please complete all items before asking a LiteLLM maintainer to review your PR
tests/litellm/directory, Adding at least 1 test is a hard requirement - see detailsmake test-unitType
🐛 Bug Fix
Changes
Replaced direct dictionary access detail["tokenCount"] with the safer .get("tokenCount", 0) method
Added a default value of 0 when the "tokenCount" key is missing
This prevents KeyError exceptions when processing audio tokens where the "tokenCount" field might be missing