-
Notifications
You must be signed in to change notification settings - Fork 443
chore(llmobs): dac strip io from anthropic #13767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 281 ± 3 ms. The average import time from base is: 286 ± 3 ms. The import time difference between this PR and base is: -5.1 ± 0.1 ms. Import time breakdownThe following import paths have shrunk:
|
BenchmarksBenchmark execution time: 2025-07-01 19:08:50 Comparing candidate commit 7aeb95f in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 427 metrics, 3 unstable metrics. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few comments, but glad the integration code was trimmed down so much! Looks great!
@@ -155,7 +154,7 @@ def _process_finished_stream(integration, span, args, kwargs, streamed_chunks): | |||
try: | |||
resp_message = _construct_message(streamed_chunks) | |||
if integration.is_pc_sampled_span(span): | |||
_tag_streamed_chat_completion_response(integration, span, resp_message) | |||
_tag_streamed_chat_completion_usage(integration, span, resp_message) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this depend on integration.is_pc_sampled_span
?
tests/snapshots/tests.contrib.anthropic.test_anthropic.test_anthropic_llm.json
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Remove potentially sensitive i/o data from apm spans. This way, prompt and completion data will only appear on the llm obs spans, which are/will be subject to data access controls.
Mostly, this just removes io tag sets. A few things (mostly metrics) have llmobs tags dependent on span tags, so there is a bit more refactoring there.
Let me know if I removed anything that should really stay, or if I missed something that should be restricted.
Checklist
Reviewer Checklist