feat(tracer): deprecate escaped and timestamp attributes in record_exception API #13798
+116
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Circular import analysis🚨 New circular imports detected 🚨The following circular imports among modules have been detected on this PR, when compared to the base branch: Please consider refactoring your changes in accordance to the Separation of Concerns principle. |
|
|
![datadog-datadog-prod-us1[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
dubloom
changed the title
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 278 ± 5 ms. The average import time from base is: 281 ± 5 ms. The import time difference between this PR and base is: -3.4 ± 0.2 ms. Import time breakdownThe following import paths have grown:
|
dubloom
changed the title
BenchmarksBenchmark execution time: 2025-06-30 16:09:47 Comparing candidate commit 29a9ec1 in PR branch Found 0 performance improvements and 6 performance regressions! Performance is the same for 564 metrics, 2 unstable metrics. scenario:iastaspects-format_map_aspect
scenario:iastaspectsospath-ospathbasename_aspect
scenario:iastaspectsospath-ospathjoin_aspect
scenario:iastaspectsospath-ospathnormcase_aspect
scenario:iastaspectsospath-ospathsplitdrive_aspect
scenario:telemetryaddmetric-1-distribution-metric-1-times
|
emmettbutler
approved these changes
Jun 27, 2025
emmettbutler
added
changelog/no-changelog
dubloom
force-pushed
the
dubloom/record-exception-follows-rfc
branch
from
9543c09 to
7bc2491
Compare
mabdinur
approved these changes
Jun 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
record_exceptioncall was added few releases ago because some customers were asking to be able to send manually errors. However, it was mainly based on the OpenTelemetry implementation. The OTEL sdk are inconsistent between tracers and some implementations are using for exampleescapedattribute which does not make sense at all for us.An RFC was written to ease the implementation across tracer. This PR is there to make the python implementation consistent with the RFC.
Changes
escapedandtimestampattributesrecord_exceptiondoc.Checklist
Reviewer Checklist