Skip to content

Improve SSI #4366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from
Draft

Improve SSI #4366

wants to merge 8 commits into from

Conversation

lloeki
Copy link
Member

@lloeki lloeki commented Feb 11, 2025

What does this PR do?

General improvements to the current SSI injector bootstrap implementation

Motivation:

Some things are not quite covered.

Change log entry

Additional Notes:

How to test the change?

It's a bit hard right now, either we have small granularity CI but a lot of environmental invasion (rspec) or we have isolation but coarse granularity (vaccine). Working on it.

Copy link

github-actions bot commented Feb 11, 2025

👋 Hey @lloeki, please fill "Change log entry" section in the pull request description.

If changes need to be present in CHANGELOG.md you can state it this way

**Change log entry**

Yes. A brief summary to be placed into the CHANGELOG.md

(possible answers Yes/Yep/Yeah)

Or you can opt out like that

**Change log entry**

None.

(possible answers No/Nope/None)

Visited at: 2025-06-17 14:01:11 UTC

@github-actions github-actions bot added the single-step Single Step APM Instrumentation label Feb 11, 2025
@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Feb 11, 2025

Datadog Report

Branch report: lloeki/ssi
Commit report: 481cf7f
Test service: dd-trace-rb

✅ 0 Failed, 21765 Passed, 1296 Skipped, 4m 38.86s Total Time

@codecov-commenter
Copy link

codecov-commenter commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.53%. Comparing base (783b428) to head (2707abf).
Report is 60 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4366      +/-   ##
==========================================
- Coverage   97.56%   97.53%   -0.03%     
==========================================
  Files        1486     1484       -2     
  Lines       88592    88498      -94     
  Branches     4589     4588       -1     
==========================================
- Hits        86431    86315     -116     
- Misses       2161     2183      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pr-commenter
Copy link

pr-commenter bot commented Feb 11, 2025

Benchmarks

Benchmark execution time: 2025-06-30 17:15:44

Comparing candidate commit 2707abf in PR branch lloeki/ssi with baseline commit 783b428 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 41 metrics, 6 unstable metrics.

@lloeki lloeki force-pushed the lloeki/ssi branch 5 times, most recently from e7b84d1 to 4667b63 Compare February 19, 2025 10:54
@lloeki lloeki force-pushed the lloeki/ssi branch 7 times, most recently from 392b10a to bb5d652 Compare June 18, 2025 14:38
@TonyCTHsu TonyCTHsu self-requested a review June 24, 2025 07:55
injector_ref="lloeki/testing"
injector_path="${HOME}/datadog-injector-rb"

git clone "${injector_repo}" --branch "${injector_ref}" "${injector_path}"
Copy link
Contributor

@TonyCTHsu TonyCTHsu Jun 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before its completion, it should be versioned with SHA or tag to be deterministic.

@lloeki lloeki force-pushed the lloeki/ssi branch 4 times, most recently from d7a0581 to 2348edd Compare June 29, 2025 15:49
@lloeki lloeki force-pushed the lloeki/ssi branch 4 times, most recently from 481cf7f to f5dfc47 Compare June 30, 2025 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
single-step Single Step APM Instrumentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants