-
Notifications
You must be signed in to change notification settings - Fork 394
Improve SSI #4366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Improve SSI #4366
Conversation
👋 Hey @lloeki, please fill "Change log entry" section in the pull request description. If changes need to be present in CHANGELOG.md you can state it this way **Change log entry**
Yes. A brief summary to be placed into the CHANGELOG.md (possible answers Yes/Yep/Yeah) Or you can opt out like that **Change log entry**
None. (possible answers No/Nope/None) Visited at: 2025-06-17 14:01:11 UTC |
Datadog ReportBranch report: ✅ 0 Failed, 21765 Passed, 1296 Skipped, 4m 38.86s Total Time |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4366 +/- ##
==========================================
- Coverage 97.56% 97.53% -0.03%
==========================================
Files 1486 1484 -2
Lines 88592 88498 -94
Branches 4589 4588 -1
==========================================
- Hits 86431 86315 -116
- Misses 2161 2183 +22 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
e7b84d1
to
4667b63
Compare
392b10a
to
bb5d652
Compare
injector_ref="lloeki/testing" | ||
injector_path="${HOME}/datadog-injector-rb" | ||
|
||
git clone "${injector_repo}" --branch "${injector_ref}" "${injector_path}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before its completion, it should be versioned with SHA or tag to be deterministic.
Ruby 2.6 showed up a lot in telemetry.
d7a0581
to
2348edd
Compare
481cf7f
to
f5dfc47
Compare
What does this PR do?
General improvements to the current SSI injector bootstrap implementation
Motivation:
Some things are not quite covered.
Change log entry
Additional Notes:
How to test the change?
It's a bit hard right now, either we have small granularity CI but a lot of environmental invasion (rspec) or we have isolation but coarse granularity (vaccine). Working on it.