Skip to content

Make the remaining bundle files typed: true #20128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 29, 2025
Merged

Make the remaining bundle files typed: true #20128

merged 4 commits into from
Jun 29, 2025
+33 −17

Conversation

issyl0
Copy link
Member

@issyl0 issyl0 commented Jun 17, 2025

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

MikeMcQuaid
MikeMcQuaid approved these changes Jun 17, 2025
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks again!

@MikeMcQuaid MikeMcQuaid enabled auto-merge June 17, 2025 14:23
@MikeMcQuaid
Copy link
Member

@issyl0 Fixed brew style for you but brew tests still failing.

@issyl0
Copy link
Member Author

issyl0 commented Jun 17, 2025

I did this and then put my laptop away for a few hours. I'll get back to this probably when it's dark!

@issyl0 issyl0 force-pushed the some-bundle-files-werent-typed-at-all branch from be257bc to a37ed04 Compare June 19, 2025 11:05
MikeMcQuaid
MikeMcQuaid reviewed Jun 19, 2025
View reviewed changes
MikeMcQuaid
MikeMcQuaid approved these changes Jun 19, 2025
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@issyl0 May be worth splitting out the non-exec changes?

@issyl0 issyl0 marked this pull request as draft June 20, 2025 08:02
auto-merge was automatically disabled June 20, 2025 08:02

Pull request was converted to draft

issyl0 added a commit that referenced this pull request Jun 20, 2025
@issyl0
Make some of the bundle commands Sorbet typed: true
68596ec 
- The last remaining one is `exec` but that's a bit more involved
  (#20128 (comment)).
@issyl0 issyl0 mentioned this pull request Jun 20, 2025
Merged
7 tasks
@issyl0 issyl0 force-pushed the some-bundle-files-werent-typed-at-all branch from a37ed04 to 5fed8f4 Compare June 26, 2025 22:23
@dduugg dduugg mentioned this pull request Jun 29, 2025
Merged
7 tasks
dduugg
dduugg reviewed Jun 29, 2025
View reviewed changes
@issyl0 issyl0 marked this pull request as ready for review June 29, 2025 19:06
@issyl0 issyl0 added this pull request to the merge queue Jun 29, 2025
Merged via the queue into main with commit 019a799 Jun 29, 2025
33 checks passed
@issyl0 issyl0 deleted the some-bundle-files-werent-typed-at-all branch June 29, 2025 23:24
@MikeMcQuaid
Copy link
Member

Thanks for this @issyl0 and @dduugg!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

@dduugg dduugg dduugg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@issyl0 @MikeMcQuaid @dduugg