Skip to content

[backport -> release/3.9.x] fix(plugin): fix ai latency metric doesn't correctly calculated issue #14653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: release/3.9.x
Choose a base branch
from

Conversation

team-gateway-bot
Copy link
Collaborator

Automated backport to release/3.9.x, triggered by a label in #14639.

Original description

Summary
Fix the prometheus plugin flaky test cases on AI metrics.

Root Cause:
AI metrics latency are floor evaluation, which means it could be 0, but AI metrics latency histogram only observe when latency is larger than 0, which may lead to missing increment of histogram.

Solution:

  1. like other non-AI latency histogram, latency 0 should also be observed.
  2. for test cases, Add waiting logic to wait the new latency calculation done.

Summary

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix KAG-7113

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee plugins/prometheus size/S skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants