MDEV-36107: Add expression support to mysqltest #4114
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svoj
added
the
External Contribution
KhaledR57
force-pushed
the
MDEV-36107-mysqltest-expressions
branch
from
bdfa044 to
12584b8
Compare
KhaledR57
force-pushed
the
MDEV-36107-mysqltest-expressions
branch
2 times, most recently
from
8b9df35 to
ddfb470
Compare
Add support for evaluating complex expressions within mysqltest to enable more powerful and dynamic testing. A new, explicit `$(...)` syntax is introduced for the `let`, `if`, and `while` commands. This allows for safe evaluation of expressions without affecting the behavior of existing tests. The engine includes an simple internal type system that distinguishes between integers and strings, ensuring that operations are type-safe and behave predictably. This foundation supports arithmetic, comparison, and logical operators, making it possible to write more sophisticated and readable test logic.
KhaledR57
force-pushed
the
MDEV-36107-mysqltest-expressions
branch
from
ddfb470 to
a29a805
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
letcommand can now evaluate mathematical and logical expressions.Release Notes
This patch integrates a recursive descent parser to handle arithmetic, comparisons, and logical operators.
TODO: Still working on it
To maintain backward compatibility, a heuristic function first checks if the right-hand side of an assignment looks like an expression. If not, the original string assignment logic is used.
How can this PR be tested?
$ ./mtr main.mysqltest_expression_evaluationBasing the PR against the correct MariaDB version
mainbranch.PR quality check