cluster: use CTP as the transport for compute and storage protocol connections #32897
+1,351
−78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a new transport protocol for bidirectional message-stream communication between controllers and cluster replicas, called CTP. The intention is to replace gRPC with a much simpler protocol and implementation, to reduce complexity.
This commit adds server fqdn validation to CTP. Having this is important to avoid confusion when clients connect to the wrong server endpoint because of stale DNS caches.
This commit adds timeouts to CTP connections. Each read or write from the underlying stream is wrapped in a timeout, and the connection fails if a timeout is triggered. To avoid triggering timeouts on idle but healthy connections, keepalive messages are introduced.
This commit makes the CTP server bound the number of active client connections to one, by canceling the current connection upon accepting a new one.
This commit adds support for connection metrics tracking to CTP. For now the reported metrics are limited to the number of bytes sent and received, together with the corresponding payloads.
CTP requires all messages to impl the serde traits, so this commit adds them where they were missing.
This commit extends the replica server code with support for CTP as the controller connection transport, in addition to the existing gRPC transport. It introduces a new command line flag, `--use-ctp`, to select between the two.
This commit makes the controller use CTP for controller connections by default. Both the replica tasks and the orchestrator are configured accordingly. For now it is still possible to revert to gRPC using a feature flag.
teskje
force-pushed
the
ctp-for-compute-storage
branch
from
118aaea to
7f1ee96
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(The first 5 commits are from #32330 and can be ignored here.)
Motivation
Tips for reviewer
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.