-
Notifications
You must be signed in to change notification settings - Fork 185
Update platform tiers #1448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update platform tiers #1448
Conversation
Also, according to https://cibuildwheel.pypa.io/en/stable/options/#linux-image i686 is going to be deleted on |
Pull Request Test Coverage Report for Build 16009961272Details
💛 - Coveralls |
we are keeping the tests as they are + adding aarch64 tests |
Test run: https://github.com/IvanIsCoding/rustworkx/actions/runs/14986825229 (excluding macOS, but no changes were made to macOS tiers) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall I'm fine with these changes they all make sense. I had a few inline suggestions, comments, and musings. But nothing major. I am wondering if we want to rethink our CI structure a bit though to try and reduce the number of jobs we're running. It does seem to be quite a lot now.
- Distributions compatible with the `manylinux 2014`_ packaging specification | ||
* - Linux | ||
- pp64le | ||
- :ref:`tier-3` | ||
- :ref:`tier-4` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are runner options for open source projects on the IBM CPU architectures now: https://community.ibm.com/community/user/ibmz-and-linuxone/blogs/elizabeth-k-joseph1/2025/05/19/expanding-open-source-access-hosted-github-actions if we were interested (not that I think we really are) in raising the level here we could investigate those. But I think the usage on these platforms is low enough that it doesn't warrant a higher tier of support right now.
TBH, I didn't remember we had ppc64le at tier 3. Downgrading it makes sense to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we could use those projects for the release, that itself would be very interesting.
But it seems QEMU is working for this time. So maybe for 0.18
Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
So, I added all aarch64 tests but I think as a follow up we could have the following structure:
Then we run a nightly build or a build every other day as I'd rather do that change after 0.17 though. |
* Change platform tiers * Add release notes explaining platform tier changes * Minor grammar correction * Apply suggestions from code review Co-authored-by: Matthew Treinish <mtreinish@kortar.org> * Adding all aarch64 tests --------- Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
Closes #1378
The changes are in the relase note, but a summary is:
rust-numpy
have seriously considered dropping it