Skip to content

Fix: add NULL check in cJSON_InsertItemInArray #7741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

hsuk04
Copy link

@hsuk04 hsuk04 commented Jun 14, 2025

Description of PR

Applying a fix from the original codebase that has not been applied here yet.
This adds a NULL check in cJSON_InsertItemInArray.

Referenced from the original commit here:
DaveGamble/cJSON@60ff122

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 40m 15s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 1s codespell was not available.
+0 🆗 detsecrets 0m 1s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
-1 ❌ mvninstall 37m 25s /branch-mvninstall-root.txt root in trunk failed.
+1 💚 compile 1m 22s trunk passed
+1 💚 mvnsite 0m 50s trunk passed
+1 💚 shadedclient 74m 14s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 36s the patch passed
+1 💚 compile 1m 13s the patch passed
-1 ❌ cc 1m 13s /results-compile-cc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager generated 3 new + 51 unchanged - 0 fixed = 54 total (was 51)
+1 💚 golang 1m 13s the patch passed
+1 💚 javac 1m 13s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 mvnsite 0m 38s the patch passed
+1 💚 shadedclient 34m 22s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 28m 12s hadoop-yarn-server-nodemanager in the patch passed.
+1 💚 asflicense 0m 40s The patch does not generate ASF License warnings.
181m 23s
Subsystem Report/Notes
Docker ClientAPI=1.50 ServerAPI=1.50 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7741/1/artifact/out/Dockerfile
GITHUB PR #7741
Optional Tests dupname asflicense compile cc mvnsite javac unit codespell detsecrets golang
uname Linux 3c264c0264b7 5.15.0-136-generic #147-Ubuntu SMP Sat Mar 15 15:53:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 5355060
Default Java Red Hat, Inc.-1.8.0_412-b08
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7741/1/testReport/
Max. process+thread count 700 (vs. ulimit of 5500)
modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7741/1/console
versions git=2.9.5 maven=3.6.3
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants