Skip to content

HADOOP-19599. Fix file permission errors as per the platform #7767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

GauthamBanasandra
Copy link
Member

Description of PR

  • The file permission denial error message in Linux systems end with (Permission denied) particularly.
  • However, an error message in the same scenario on Windows ends with an (Access is denied) error.
  • This PR fixes the resulting bug in org.apache.hadoop.fs.ChecksumFileSystem.ChecksumFSInputChecker and also fixes the unit test failure org.apache.hadoop.fs.TestFsShellCopy#testPutSrcFileNoPerm by making the appropriate check in accordance with the platform.

How was this patch tested?

  1. Ran the unit test locally (for Windows).
  2. CI validation (for Windows and Linux).

For code changes:

  • Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

* The file permission denial error message in Linux
  systems end with `(Permission denied)` particularly.
* However, an error message in the same scenario on
  Windows ends with an `(Access is denied)` error.
* This PR fixes the resulting bug in
  `org.apache.hadoop.fs.ChecksumFileSystem.ChecksumFSInputChecker`
  and also fixes the unit test failure
  `org.apache.hadoop.fs.TestFsShellCopy#testPutSrcFileNoPerm`
  by making the appropriate check in accordance with the platform.
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes file permission error messages in Hadoop by adjusting the logic for both Windows and Linux platforms. Key changes include:

  • Updating the unit test in TestFsShellCopy to assert platform-specific error messages.
  • Refactoring ChecksumFileSystem to use a helper method (isPermissionDenied) for detecting permission denied errors.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
hadoop-common/src/test/java/org/apache/hadoop/fs/TestFsShellCopy.java Adjusts error message assertion to handle Windows "(Access is denied)" and Linux "(Permission denied)" messages.
hadoop-common/src/main/java/org/apache/hadoop/fs/ChecksumFileSystem.java Introduces a helper method to encapsulate permission denied error detection based on platform.

@hadoop-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 34s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+1 💚 mvninstall 40m 27s trunk passed
+1 💚 compile 17m 39s trunk passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 💚 compile 15m 14s trunk passed with JDK Private Build-1.8.0_452-8u452-gaus1-0ubuntu120.04-b09
+1 💚 checkstyle 1m 15s trunk passed
+1 💚 mvnsite 1m 39s trunk passed
+1 💚 javadoc 1m 19s trunk passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 💚 javadoc 0m 54s trunk passed with JDK Private Build-1.8.0_452-8u452-gaus1-0ubuntu120.04-b09
+1 💚 spotbugs 2m 44s trunk passed
+1 💚 shadedclient 40m 34s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 56s the patch passed
+1 💚 compile 15m 6s the patch passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 💚 javac 15m 6s the patch passed
+1 💚 compile 13m 56s the patch passed with JDK Private Build-1.8.0_452-8u452-gaus1-0ubuntu120.04-b09
+1 💚 javac 13m 56s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 1m 14s the patch passed
+1 💚 mvnsite 1m 39s the patch passed
+1 💚 javadoc 1m 13s the patch passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 💚 javadoc 0m 55s the patch passed with JDK Private Build-1.8.0_452-8u452-gaus1-0ubuntu120.04-b09
+1 💚 spotbugs 2m 44s the patch passed
+1 💚 shadedclient 37m 28s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 23m 11s hadoop-common in the patch passed.
+1 💚 asflicense 1m 3s The patch does not generate ASF License warnings.
223m 7s
Subsystem Report/Notes
Docker ClientAPI=1.51 ServerAPI=1.51 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7767/1/artifact/out/Dockerfile
GITHUB PR #7767
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname Linux 025cb87d9eff 5.15.0-139-generic #149-Ubuntu SMP Fri Apr 11 22:06:13 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / f8aa659
Default Java Private Build-1.8.0_452-8u452-gaus1-0ubuntu120.04-b09
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_452-8u452-gaus1-0ubuntu120.04-b09
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7767/1/testReport/
Max. process+thread count 1271 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7767/1/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

Copy link
Contributor

@ASHISH-RANJAN59 ASHISH-RANJAN59 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@ayushtkn ayushtkn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants