Make debugging source mapping optional #7664
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue number: bazelbuild#7663 Intellij maps /proc/self/cwd -> workspace root which is likely logic specific to Google Forge builds and creates issues for intellij when it tries to resolve sources. It also assumes Linux only builds which is not the case outside google This PR allows to turn off the mapping using the registry key `bazel.cpp.debug.map_working_dir`
mauriciogg
requested review from
mai93,
ujohnny,
LeFrosch and
agluszak
as code owners
github-actions
bot
added
product: CLion
odisseus
added
product: Android Studio
|
@mai93, can you review these changes in the context of Android Studio? I see no point in merging them into this repository. |
|
I think this is related to https://issuetracker.google.com/issues/409978995, if so can you mention any relevant PRs there? so the ASwB team can check them. If they think a PR is acceptable, I can help merging it to AOSP. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Please note that the maintainers will not be reviewing this change until all checkboxes are ticked. See
the Contributions section in the README for more
details.
Discussion thread for this change
Issue number: Issue number: #7663
Description of this change
ASwB maps /proc/self/cwd -> workspace root which is likely logic specific to Google Forge builds and creates issues for Android Studio when it tries to resolve sources. It also assumes Linux only builds which is not the case outside google This PR allows to turn off the mapping using the registry key
bazel.cpp.debug.map_working_dir