Fix: pass adb path to mobile-install launcher and canonicalize #350
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pswaminathan
force-pushed
the
p/stacked/mi-adb-path
branch
from
708d16e to
2a9ee95
Compare
Path to `adb` was not being sent to MI launcher. This caused it to use the default `/usr/bin/adb`, which is not always valid. stacked-branch: mi-adb-path
pswaminathan
force-pushed
the
p/stacked/mi-adb-path
branch
from
2a9ee95 to
68b19e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Path to
adbwas not being sent to MI launcher. This caused it to use the default/usr/bin/adb, which is not always valid.Fixes #349