Filter abi jar from jdeps classpath #1340
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbeazleyspot
requested review from
ahumesky,
cgruber,
restingbull,
Bencodes and
nkoroste
as code owners
rbeazleyspot
force-pushed
the
rework_direct_deps
branch
from
450aab7 to
054d6a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following on from #1337 (a particularly l33t PR), it was noticed that the
--direct_dependencies(used for the jdeps compiler plugin) include the ABI jar for an associate when instead the runtime class jar should be used.This is a proposal to remedy this, instead of generating a list of compile jars from the targets deps at the point of compiler flag generation. This list is pre-generated in the jvm_deps functions where the abi jar can be filtered out.
It turns out that this list is identical to the compile_jars list when experimental_prune_transitive_deps is enabled, so when this stops being experimental things should get much simpler.