Crate Universe: crate.spec() supports path
#3464
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
The crate.bzl change looks good to me, but I'm not quite sure why the LocalPath pieces are necessary, I wouldn't expect them to be and suspect we can fix something somewhere else to obviate the need - can you put together an integration test and we can poke at what goes wrong without LocalPath?
rickvanprim
force-pushed
the
jleitch
branch
13 times, most recently
from
fb616b4 to
ba20200
Compare
rickvanprim
changed the title
path on crate.spec() and split off LocalPath from Pathcrate.spec() supports path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposes
pathoncrate.spec()(which just works withcargo metadata🎉).However if the
pathis outside of the Bazel workspace, it attempts to generate dependency paths in the form//<absolute path>(which don't exist), so this splitsSourceAnnotation::PathintoSourceAnnotation::Path(located somewhere on the file system) andSourceAnnotation::LocalPath(located relative to the Bazel workspace).