This repository was archived by the owner on Nov 28, 2018. It is now read-only.
fixed bug with space added in a return frame. #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry to have let this go forgotten. I suck. 😞 I think we should handle this a bit earlier in the process, like when we extract the headers from the payload. Also, I'm pretty sure node has a string trim. We're already extracting them as strings, so we should probably just do that. I'll whip up a fresh patch later tonight. |
benjaminws
added a commit
that referenced
this pull request
Mar 6, 2013
…lay boyscout, leave it a bit better than I found it.
|
I'm not going to merge this. I addressed it in a different way. Thanks for bringing it to my attention! So it's tracked, e4f84de also contains a fix because I'm a dum dum |
|
Sounds good. Thanks. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a return frame passed from the server has a space added to all teh values in the headers. Maybe other properties too.
When we try to retrieve the this_frame.headers.destination property of -subscribed_to an error is thrown.