Skip to content
This repository was archived by the owner on Nov 28, 2018. It is now read-only.

Adding support for vhost host header (required in Stomp 1.1 protocol) #23

Merged
merged 1 commit into from
Mar 6, 2013

Conversation

thurmda
Copy link
Contributor

@thurmda thurmda commented Mar 5, 2013

We recently switched to using Vhosts to segment our queues and I need to use the host header defined in the Stomp 1.1 protocol.

http://stomp.github.com/stomp-specification-1.1.html#CONNECT_or_STOMP_Frame

I'm actually not that familiar with the Stomp changes for the 1.0 => 1.1 protocol shift. I'd be happy to add them too if you really care to support it. The vhost header was all I needed to get my project back on track after our change in queue management.

i.e. I am creating my client like this:

var client = new stomp.Stomp({
    port: 61613,
    host: 'rmq',
    vhost: 'MY_VIRTUAL_HOST_HEADER',
    debug: true,
});

benjaminws added a commit that referenced this pull request Mar 6, 2013
Adding support for vhost host header (required in Stomp 1.1 protocol)
@benjaminws benjaminws merged commit ad70dfc into benjaminws:master Mar 6, 2013
@benjaminws
Copy link
Owner

I haven't implemented 1.1 support at all yet. I'd like to do it all at once, but alas. 😞

I..really, I should finish this: https://github.com/benjaminws/stomp-js-new

If you want to help me get that one moving again, that'd be sweet. It's basically the same thing, revisited with a test driven approach. I started STOMP 1.1 implementation, but I have neglected to take the time to finish it. It's mostly done otherwise, sans SSL.

Anyway, thanks for your patch, I don't see any reason not to merge this in and bump the version.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants