This repository was archived by the owner on Nov 28, 2018. It is now read-only.
Fixes STOMP Protocol Issues, Adds SSL Support #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The messages produced were not completely compliant with the stomp protocol. This did not manifest until testing with SSL. http://stomp.codehaus.org/Protocol Signed-off-by: Joshua Rubin <jrubin@zvelo.com>
to use ssl, there are a few new arguments in the object passed to the
Stomp constructor:
- ssl: `{boolean}`, use ssl for the connection
- ssl_validate: `{boolean}`, disconnect if the certificate does not
validate
- ssl_options: `{object}`, passed into the tls.connect method as the
`options` parameter, see <http://nodejs.org/docs/v0.4.8/api/tls.html>
Signed-off-by: Joshua Rubin <jrubin@zvelo.com>
Signed-off-by: Joshua Rubin <jrubin@zvelo.com>
benjaminws
added a commit
that referenced
this pull request
Jun 30, 2011
Fixes STOMP Protocol Issues, Adds SSL Support
|
Perfect, thank you for your fixes! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please consider pulling this as it fixes another important bug and adds ssl support.