Skip to content

Small Typo & Lint Fix #15313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 27, 2025
Merged

Small Typo & Lint Fix #15313

merged 3 commits into from
Jun 27, 2025

Conversation

coltonhurst
Copy link
Member

@coltonhurst coltonhurst commented Jun 24, 2025

📔 Objective

This PR does 2 simple things:

  • Fixes a small typo in a comment
  • When running npm run prettier && npm run lint:fix, it removes the comment on line 2 in access-selector.component.html. This applies that change so it's not included in unrelated PR's. If someone on the admin console team can verify this change should be applied that would be great!

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link

codecov bot commented Jun 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.89%. Comparing base (012ce25) to head (ccfd718).
Report is 31 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #15313   +/-   ##
=======================================
  Coverage   36.89%   36.89%           
=======================================
  Files        3227     3227           
  Lines       93254    93254           
  Branches    14030    14030           
=======================================
  Hits        34406    34406           
  Misses      57424    57424           
  Partials     1424     1424           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@coltonhurst coltonhurst marked this pull request as ready for review June 24, 2025 13:17
@coltonhurst coltonhurst requested review from a team as code owners June 24, 2025 13:17
Copy link
Contributor

github-actions bot commented Jun 24, 2025

Logo
Checkmarx One – Scan Summary & Detailsdf177ad7-f0ad-4257-93e1-156e3c7d2771

New Issues (1)

Checkmarx found the following issues in this Pull Request

Severity Issue Source File / Package Checkmarx Insight
HIGH CVE-2025-5280 Npm-electron-36.4.0
detailsDescription: Out-of-bounds Write in V8 in Google Chrome prior to 137.0.7151.55 allowed a remote attacker to potentially exploit heap corruption via a crafted HT...
Attack Vector: NETWORK
Attack Complexity: LOW

ID: fLK7Tjr9xcX%2FcsO%2FwaNmaooHh3VCO%2BVqZovj%2BhCIETc%3D
Vulnerable Package

Copy link

@coltonhurst coltonhurst merged commit f7ca5b7 into main Jun 27, 2025
68 of 69 checks passed
@coltonhurst coltonhurst deleted the TypoAndLintFix branch June 27, 2025 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants