feat(change-password): [PM-18720] (#5319) Change Password Implementation for Non Dialog Cases #15319
+1,312
−546
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y close to complete.
… Removed temp code to force the state I need to verify correctness.
…ord-component-non-dialog-v3
… Recover account working with change password component.
… Made code more dry.
…tes to routing and the extension. Extension is still a wip.
…nsion routing changes.
…sing work for now while we wait for product to hear back.
…oved duplicated anon layouts.
…ll fixes to the styling
…ing more content for the routing.
…oved circular loop for now.
…e comments regarding the change password routing complexities with change-password and auth guard.
…ord-component-non-dialog-v3
…id some changes because they will be conflicts later on.
…ll directive change.
…ll changes and added some clarification on where I'm blocked
… invite is seemingly working, found one bug to iron out.
…ord-component-non-dialog-v3
…ord-component-non-dialog-v3
…ord-component-non-dialog-v3
… Fixed up policy service to be made more clear.
…ated documentation.
… Routing changes and policy service changes.
…ord-component-non-dialog-v3
…ord-component-non-dialog-v3
…uld be working fully
…ved duplicative services module entry.
…d unneeded call in two factor to get user id.
…d a couple of tiny things.
…d comment for later fix.
JaredSnider-Bitwarden
requested changes
Jun 25, 2025
…fter other conditions for efficiency.
…bine org invite policies logic for weak password evaluation.
…dialog-pared-down
…t of input password component
…dialog-pared-down
…password-component-non-dialog-pared-down + auth guard merge conflict
…password-component-non-dialog-pared-down + merge conflicts
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-18720
📔 Objective
This work aims to utilize the change password shared component for the following flows:
Tweaks to the order of operations we are doing in the password-login.strategy and the login.component were made as well to try to reduce complexity / duplicate pw checking. There is a separate pr with more changes that we had to step back from because it was growing too great in scope and we want to work with the AC team to assist in some of those changes. The complexity of this task grew because we originally had two separate components that existed specifically in the web component that could be used / routed to independently. Now that we have one shared component, that grew the scope and there were unforeseen changes.
Other work
Here are the reasons for the other group's involvement:
📸 Screenshots
Org Invite Scenarios (Web only):
Login with Weak Password
Admin Account Recovery
Video Flows FF Off
Org Invite, Admin account recovery, Login with weak password
[STUB]
2FA and New Device Verification Flows
[STUB]
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes