-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Risk Insights persistance feature outline #15329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Banrion
wants to merge
3
commits into
dirt/feature/risk-insights-saving-reports
from
dirt/risk-insights-saving-reports-outline
Closed
Risk Insights persistance feature outline #15329
Banrion
wants to merge
3
commits into
dirt/feature/risk-insights-saving-reports
from
dirt/risk-insights-saving-reports-outline
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New Issues (48)Checkmarx found the following issues in this Pull Request
|
Obselete now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📔 Objective
This pull request creates an outline for shared requirements across the services and angular components.
The outline references changes already made that will be split into three branches that capture the scope of the jira tickets.
PM-20578
Api service - responsible for interacting with the api- making the save and the get calls
PM-20579
Report service - responsible for taking the data from the api and manipulating it into the reports
Encryption service - consumes data from the report service to handle decryption and encryption
PM-20580
Risk insights data service - responsible for shared component variables
Client side code - update angular components
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes