-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[CL-620] add padding to increase checkbox clickable area #15331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Great job, no security vulnerabilities found in this Pull Request |
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #15331 +/- ##
==========================================
- Coverage 37.15% 37.14% -0.01%
==========================================
Files 3272 3272
Lines 94367 94368 +1
Branches 14226 14226
==========================================
- Hits 35062 35055 -7
- Misses 57855 57863 +8
Partials 1450 1450 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of stories that look a little off:
- Form > checkbox > disabled
- Vault > items > individual -- the checkbox in the header is misaligned. I remember this one being annoying to deal with the last time I made checkbox changes
|
🎟️ Tracking
https://bitwarden.atlassian.net/browse/CL-620
📔 Objective
Increase size of checkbox clickable area
In order to achieve this I needed to:
::before
element::after
elementbit-form-control
component📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes