PM-20578 Added api to fetch and save data #15334
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New Issues (48)Checkmarx found the following issues in this Pull Request
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## dirt/feature/risk-insights-saving-reports #15334 +/- ##
=============================================================================
+ Coverage 36.83% 36.88% +0.04%
=============================================================================
Files 3230 3231 +1
Lines 93448 93531 +83
Branches 14064 14079 +15
=============================================================================
+ Hits 34424 34498 +74
- Misses 57598 57604 +6
- Partials 1426 1429 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ttalty
requested changes
Jun 27, 2025
There was a problem hiding this comment.
⛏️ Can you add test cases for getRiskInsightsReport and the error cases?
There was a problem hiding this comment.
done. Added test cases for the error cases as well. Thanks for catching this.
ttalty
requested changes
Jun 30, 2025
| throw error; // Re-throw other errors | ||
| }); | ||
|
|
||
| if (dbResponse instanceof Error) { |
There was a problem hiding this comment.
⛏️ Every other test case covered. Thank you. I know this one is a real pick but could we get a test case for this one like the other errors?
There was a problem hiding this comment.
thanks for catching this Tom. The line of code would not execute. That's because the catch in the earlier block would handle all errors and therefore, dbResponse is never an instance of Error. I removed that line of code.
|
ttalty
approved these changes
Jul 1, 2025
voommen-livefront
merged commit e591773
into
dirt/feature/risk-insights-saving-reports
53 checks passed
voommen-livefront
deleted the
dirt/pm-20578/create-risk-insights-api-service-2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-20578
📔 Objective
Create an api service that fetches and saves data
📸 Screenshots
none at this time
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes