[PM-22181] Delete shared TOTP items if PM app is uninstalled #1675
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great job, no security vulnerabilities found in this Pull Request |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1675 +/- ##
==========================================
- Coverage 89.38% 85.74% -3.65%
==========================================
Files 798 996 +198
Lines 50450 60343 +9893
==========================================
+ Hits 45094 51739 +6645
- Misses 5356 8604 +3248 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
AuthenticatorShared/Core/Vault/Repositories/AuthenticatorItemRepository.swift
Outdated
Show resolved
Hide resolved
AuthenticatorShared/Core/Vault/Repositories/AuthenticatorItemRepository.swift
Show resolved
Hide resolved
matt-livefront
approved these changes
Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-22181
📔 Objective
This updates BWA so that when it goes to build the item list, if it detects that the PM app has been uninstalled, it purges the shared storage of TOTP items and the shared Authenticator key.
As well, this adds that when BWA sync is turned on in PM, it updates the last active time. This handles a corner case where through uninstalling/reinstalling, it's possible to not have that data in the keychain and cause an error.
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes