Skip to content

fix(tests): fix make example tests #2007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 25, 2025
Merged

fix(tests): fix make example tests #2007

merged 1 commit into from
Jun 25, 2025

Conversation

bpg
Copy link
Owner

@bpg bpg commented Jun 25, 2025

Contributor's Note

The LXC container image link had rotten, so updated it.
Also fixed the template for the debian VM, as apparently it requires serial device for cloud init image 🙄

  • I have added / updated documentation in /docs for any user-facing features or additions.
  • I have added / updated acceptance tests in /fwprovider/tests for any new or updated resources / data sources.
  • I have ran make example to verify that the change works as expected.

Proof of Work

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #0000 | Relates #0000

Summary by CodeRabbit

  • New Features

    • Added an empty serial device configuration option for virtual machine resources.
  • Chores

    • Updated Ubuntu 24 LXC image references, URLs, and checksums to use the latest 2025-06-10 release across all relevant configurations and variables.

Signed-off-by: Pavel Boldyrev <627562+bpg@users.noreply.github.com>
Copy link

coderabbitai bot commented Jun 25, 2025

Walkthrough

The changes update references to the Ubuntu 24 LXC image from the 20240725 release to the newer 20250610 release across Terraform configuration files. Variable names, default values, resource names, URLs, and checksums are updated accordingly. Additionally, an empty serial_device block is added to a virtual machine resource.

Changes

Files Change Summary
example/resource_virtual_environment_container.tf Updated template_file_id in operating_system block to reference Ubuntu 24 LXC image 20250610.
example/resource_virtual_environment_download_file.tf Renamed resource and updated URL/checksum references from 20240725 to 20250610 for Ubuntu 24 LXC image.
example/variables.tf Renamed variables and updated defaults for Ubuntu 24 LXC image to 20250610 release and checksum.
example/resource_virtual_environment_trunks.tf Added an empty serial_device block to proxmox_virtual_environment_vm resource.

Suggested labels

size/XS

✨ Finishing Touches
🧪 Generate Unit Tests
  • Create PR with Unit Tests
  • Post Copyable Unit Tests in Comment
  • Commit Unit Tests in branch fix-examples-test

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai auto-generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
example/resource_virtual_environment_trunks.tf (1)

45-46: Empty serial_device {} relies on provider defaults—confirm compatibility

Older versions of the provider required at least path or type inside the block. An empty block is accepted only in ≥ v2.2 (it creates a default socket on serial0).
Double-check your minimum provider constraint or add explicit attributes for forward-compatibility.

-  serial_device {}
+  serial_device {
+    # path   = "socket"
+    # type   = "serial0"
+  }
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 221faaf and b56b238.

📒 Files selected for processing (4)
  • example/resource_virtual_environment_container.tf (1 hunks)
  • example/resource_virtual_environment_download_file.tf (1 hunks)
  • example/resource_virtual_environment_trunks.tf (2 hunks)
  • example/variables.tf (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: qodana
🔇 Additional comments (3)
example/variables.tf (1)

22-32: Verify that all example configs switched to the new variable names

release_20250610_ubuntu_24_noble_lxc_img_(url|checksum) replace the old release_20240725_* identifiers. If any file outside this PR still references the 20240725 variables, terraform plan will fail with “var not declared”.

#!/bin/bash
# Look for stray references to the old release string in the whole repo
rg --no-heading --line-number '20240725' || true
example/resource_virtual_environment_container.tf (1)

45-45: Resource reference updated correctly

template_file_id now points to release_20250610_ubuntu_24_noble_lxc_img.id, matching the new download resource. Looks good.

example/resource_virtual_environment_download_file.tf (1)

3-9: Consistent resource & variable rename looks good

The resource name and the url / checksum attributes now consume the renamed variables, keeping everything in sync with variables.tf.

@bpg bpg merged commit a76cc62 into main Jun 25, 2025
8 checks passed
@bpg bpg deleted the fix-examples-test branch June 25, 2025 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant