-
-
Notifications
You must be signed in to change notification settings - Fork 189
fix(tests): fix make example
tests
#2007
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Pavel Boldyrev <627562+bpg@users.noreply.github.com>
WalkthroughThe changes update references to the Ubuntu 24 LXC image from the 20240725 release to the newer 20250610 release across Terraform configuration files. Variable names, default values, resource names, URLs, and checksums are updated accordingly. Additionally, an empty serial_device block is added to a virtual machine resource. Changes
Suggested labels
✨ Finishing Touches🧪 Generate Unit Tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
example/resource_virtual_environment_trunks.tf (1)
45-46
: Emptyserial_device {}
relies on provider defaults—confirm compatibilityOlder versions of the provider required at least
path
ortype
inside the block. An empty block is accepted only in ≥ v2.2 (it creates a defaultsocket
onserial0
).
Double-check your minimum provider constraint or add explicit attributes for forward-compatibility.- serial_device {} + serial_device { + # path = "socket" + # type = "serial0" + }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
example/resource_virtual_environment_container.tf
(1 hunks)example/resource_virtual_environment_download_file.tf
(1 hunks)example/resource_virtual_environment_trunks.tf
(2 hunks)example/variables.tf
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: qodana
🔇 Additional comments (3)
example/variables.tf (1)
22-32
: Verify that all example configs switched to the new variable names
release_20250610_ubuntu_24_noble_lxc_img_(url|checksum)
replace the oldrelease_20240725_*
identifiers. If any file outside this PR still references the 20240725 variables,terraform plan
will fail with “var not declared”.#!/bin/bash # Look for stray references to the old release string in the whole repo rg --no-heading --line-number '20240725' || trueexample/resource_virtual_environment_container.tf (1)
45-45
: Resource reference updated correctly
template_file_id
now points torelease_20250610_ubuntu_24_noble_lxc_img.id
, matching the new download resource. Looks good.example/resource_virtual_environment_download_file.tf (1)
3-9
: Consistent resource & variable rename looks goodThe resource name and the
url
/checksum
attributes now consume the renamed variables, keeping everything in sync withvariables.tf
.
Contributor's Note
The LXC container image link had rotten, so updated it.
Also fixed the template for the debian VM, as apparently it requires serial device for cloud init image 🙄
/docs
for any user-facing features or additions./fwprovider/tests
for any new or updated resources / data sources.make example
to verify that the change works as expected.Proof of Work
Community Note
Closes #0000 | Relates #0000
Summary by CodeRabbit
New Features
Chores