Skip to content

fix(Terraform): Failing checks due to parsing error CKV_GCP_54 & CKV_GCP_57 Issue 7033 #7036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(Terraform): Failing checks due to parsing error CKV_GCP_54 & CKV_GCP_57 Issue 7033 #7036

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion checkov/terraform/checks/resource/gcp/GoogleCloudPostgreSqlLogLockWaits.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,16 @@ def scan_resource_conf(self, conf):
# treating use cases of the following database_flags parsing
# (list of dictionaries with arrays): 'database_flags':
# [{'name': ['<key>'], 'value': ['<value>']},{'name': ['<key>'], 'value': ['<value>']}]
flags = [{key: flag[key][0] for key in flag} for flag in flags]
new_flag_list = []
for flag in flags:
if "name" and "value" in flag:
new_flag_list.append(
{
"name": flag["name"][0],
"value": flag["value"][0],
}
)
flags = new_flag_list
for flag in flags:
if (isinstance(flag, dict) and flag['name'] == 'log_lock_waits') and (flag['value'] == 'on'): # Must be explicitly set for check to pass
self.evaluated_keys = ['database_version/[0]/POSTGRES',
Expand Down
11 changes: 10 additions & 1 deletion checkov/terraform/checks/resource/gcp/GoogleCloudPostgreSqlLogMinDuration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,16 @@ def scan_resource_conf(self, conf):
# treating use cases of the following database_flags parsing
# (list of dictionaries with arrays): 'database_flags':
# [{'name': ['<key>'], 'value': ['<value>']},{'name': ['<key>'], 'value': ['<value>']}]
flags = [{key: flag[key][0] for key in flag} for flag in flags]
new_flag_list = []
for flag in flags:
if "name" and "value" in flag:
new_flag_list.append(
{
"name": flag["name"][0],
"value": flag["value"][0],
}
)
flags = new_flag_list
for flag in flags:
if (isinstance(flag, dict) and flag['name'] == 'log_min_duration_statement') and (flag['value'] != '-1'):
self.evaluated_keys = ['database_version/[0]/POSTGRES',
Expand Down
Loading