Skip to content

✨ fix: Minor Menu Issues #8026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 23, 2025
Merged

✨ fix: Minor Menu Issues #8026

merged 3 commits into from
Jun 23, 2025

Conversation

danny-avila
Copy link
Owner

Summary

I improved the user experience for dropdown and submenu components by fixing focus loop handling, removing an unnecessary "Tools" header, and enabling better menu portal support.

  • Enabled the Ariakit menu focus loop in MCPSubMenu for seamless keyboard navigation
  • Improved button interaction in MCPSubMenu by updating the onClick logic to prevent event bubbling and correctly toggle the menu
  • Cleaned up MCPSubMenu properties, moved unmountOnHide to be explicit, and removed unused props for clarity
  • Removed the "Tools" header from ToolsDropdown, providing a cleaner dropdown appearance
  • Enabled portal support in ExportAndShareMenu to ensure modals render above all content and outside stacking context issues

Change Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Testing

I manually tested each dropdown menu (ToolsDropdown, ExportAndShareMenu, and MCPSubMenu) to confirm:

  • Menus appear above overlays and are not clipped by boundaries
  • Focus remains trapped within the menu while navigating with keyboard
  • Submenus open and close as expected without activating unrelated dropdowns
  • Clicking menu buttons prevents propagation, fixing unwanted parent toggling
  • The ToolsDropdown no longer displays the "Tools" header

To validate changes, I recommend checking these menu components across different browsers and devices, using both mouse and keyboard navigation.

Checklist

  • My code adheres to this project's style guidelines
  • I have performed a self-review of my own code
  • I have commented in any complex areas of my code
  • My changes do not introduce new warnings
  • Local unit tests pass with my changes

@danny-avila danny-avila merged commit 5c947be into dev Jun 23, 2025
6 checks passed
@danny-avila danny-avila deleted the fix/ui-menu-issues branch June 23, 2025 18:29
rhonyabdullah pushed a commit to rhonyabdullah/LibreChat that referenced this pull request Jun 27, 2025
* fix: Enable portal support in ExportAndShareMenu component

* fix: MCPSubMenu with focus loop and improved button click handling

* chore: remove "tools" header in toolsdropdown
@Nihanth-Reddy
Copy link

@danny-avila file search toggle is not adding any value to the conversation as it is not able to look up the files uploaded in different chats. In the chats where files are uploaded with out the file search toggle we are getting responses from the files. May I know how we are supposed to use file search?

@danny-avila
Copy link
Owner Author

In the chats where files are uploaded with out the file search toggle we are getting responses from the files.

You are getting "naive RAG" results, which is based on your message. Enabling "File Search" gives the LLM the ability to construct the queries for more targeted searches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants