Skip to content

🐛 fix: Assistants Endpoint Handling in createPayload Function #8123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 28, 2025

Conversation

danny-avila
Copy link
Owner

Summary

Closes #8100

I fixed the logic in the createPayload function to properly build the server URL for Assistants endpoints, ensuring endpointType is respected and that '/modify' is appended only for edited payloads. I also bumped the librechat-data-provider package version to 0.7.89 to reflect the update.

  • Updated the endpoint URL construction in createPayload to use endpointType when defined and handle '/modify' path only when isEdited is true for Assistants endpoints.
  • Ensured correct support for both 'assistants' and 'azureAssistants' endpoint types.
  • Incremented the version of librechat-data-provider to 0.7.89 in package.json.

Change Type

  • Bug fix (non-breaking change which fixes an issue)
  • Documentation update

Testing

I manually tested assistant endpoint payloads with and without edits, verifying that the URLs are constructed accurately for both 'assistants' and 'azureAssistants'. I recommend running regression tests for conversations using these endpoints, and checking that modified payloads reach the /modify route only when editing is intended.

Test Configuration:

  • local development
  • modified and created conversations using Assistants endpoints

Checklist

  • My code adheres to this project's style guidelines
  • I have performed a self-review of my own code
  • I have commented in any complex areas of my code
  • I have made pertinent documentation changes
  • My changes do not introduce new warnings
  • I have written tests demonstrating that my changes are effective or that my feature works
  • Local unit tests pass with my changes

@danny-avila danny-avila changed the title 🐛 fix: Correct Assistants Endpoint Handling in createPayload Function 🐛 fix: Assistants Endpoint Handling in createPayload Function Jun 28, 2025
@danny-avila danny-avila merged commit 1060ae8 into dev Jun 28, 2025
4 checks passed
@danny-avila danny-avila deleted the fix/assistants-payload branch June 28, 2025 16:33
@danny-avila danny-avila mentioned this pull request Jun 28, 2025
1 task
@walbercardoso
Copy link
Contributor

Thank you @danny-avila

miguelwon pushed a commit to miguelwon/LibreChat that referenced this pull request Jul 9, 2025
…y-avila#8123)

* 📦 chore: bump librechat-data-provider version to 0.7.89

* 🐛 fix: Assistants endpoint handling in createPayload function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants