Skip to content

Should the koans prefer in/2 over member?/2? #269

Open
@cmcaine

Description

@cmcaine

These koans use Enum.member? and MapSet.member?. I only know a little Elixir, but as far as I can tell these offer no benefit over in/2 (they're the same speed and give the same results).

Similarly, MapSet.equal?/2 is used instead of ==/2, but it doesn't need to be.

Would you accept a PR that changed lines like

assert MapSet.member?(@set, 1) == ___

into

assert (1 in @set) == ___

?

Thanks for writing/maintaining these koans!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions