adding hasOwnProperty header protection

Author: sergi-eyeos

lib/frame.js

@@ -78,7 +78,9 @@ Frame.prototype.as_string = function() {
         body = this.body;
 
     for (var header in headers) {
-       header_strs.push(header + ':' + headers[header]);
+        if (headers.hasOwnProperty(header)) {
+            header_strs.push(header + ':' + headers[header]);
+        }
     }
 
     frame += command + "\n";

package.json

@@ -1,22 +1,49 @@
 {
-  "name" : "stomp",
+  "name": "eyeos-stomp",
   "description": "Implementation of the STOMP protocol in node.js",
-  "keywords": [ "STOMP", "messaging", "queue", "protocol" ],
-  "version": "v0.1.1",
+  "keywords": [
+    "STOMP",
+    "messaging",
+    "queue",
+    "protocol"
+  ],
+  "version": "0.1.2",
   "homepage": "https://github.com/benjaminws/stomp-js",
-  "author": "Benjamin W. Smith <benjaminws@just-another.net>",
-  "contributors" : [ "rofflwaffls@gmail.com" ],
-  "main" : "lib/stomp",
-  "repository" : {
-    "type" : "git",
-    "url" : "https://benjaminws@github.com/benjaminws/stomp-js.git"
+  "author": {
+    "name": "Benjamin W. Smith",
+    "email": "benjaminws@just-another.net"
   },
-  "directories" : {
+  "contributors": [
+    {
+      "name": "rofflwaffls@gmail.com"
+    },
+    {
+      "name": "eyeos@eyeos.com"
+    }
+  ],
+  "main": "lib/stomp",
+  "repository": {
+    "type": "git",
+    "url": "https://github.com/eyeos2/stomp-js.git"
+  },
+  "directories": {
     "lib": "./lib",
     "examples": "./examples"
   },
-  "licenses" : [{
-    "type" : "BSD",
-    "url" : "https://github.com/benjaminws/stomp-js/raw/master/LICENSE"
-  }]
+  "devDependencies": {
+    "nodeunit": "0.9.0"
+  },
+  "licenses": [
+    {
+      "type": "BSD",
+      "url": "https://github.com/benjaminws/stomp-js/raw/master/LICENSE"
+    }
+  ],
+  "readme": "stomp-js\n========\n\n## Overview\n\nAn exercise with node.js to implement the STOMP protocol.\n\nFor documentation see http://benjaminws.github.com/stomp-js/\n\n## Installation\n\n`npm install stomp`\n\n`git clone https://benjaminws@github.com/benjaminws/stomp-js.git`\n\n## Examples\n\n### Consumer\n\nSee examples/stomp-consumer.js\n\n### Producer\n\nSee examples/stomp-producer.js\n\n### Producer with Transaction Support\n\nSee examples/stomp-producer-txn.js\n\n### Contributors\n\nrofflwaffls -at- gmail.com\n",
+  "readmeFilename": "README.md",
+  "bugs": {
+    "url": "https://github.com/eyeos2/stomp-js/issues"
+  },
+  "_id": "eyeos-stomp@0.1.2",
+  "_from": "eyeos-stomp@*"
 }

test/test-frame.js

@@ -63,3 +63,28 @@ module.exports['connect'] = testCase({
         test.done();
     }
 });
+
+module.exports['as_string'] = testCase({
+    'should not add extended properties from prototype': function(test) {
+        Object.prototype.foo = 'bar';
+        var Frame = require('../lib/frame.js').Frame;
+        var frame = new Frame();
+        frame.build_frame({
+            command: 'CONNECT',
+            headers: {
+                'login': 'somelogin',
+                'passcode': 'somepass'
+            }
+        });
+
+        var frame_text = frame.as_string();
+        var foo_in_frame = frame_text.indexOf('foo') !== -1;
+        test.equal(
+            foo_in_frame,
+            false,
+            "Frame should not contain the extended property foo"
+        );
+        test.done()
+        delete Object.prototype.foo;
+    }
+});