Skip to content

feat: run EAP-related containers #3778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

aldy505
Copy link
Collaborator

@aldy505 aldy505 commented Jun 24, 2025

Self-hosted e2e test is broken due to missing containers. First noticed on this commit getsentry/relay@8601508

From @phacops:

no, our plan is to ship the switch from spans to items and the buffer before that
so, that’s the right PR, might need 1 more consumers and to remove the spans one
and then, once we switched, we also switch back relay’s default to items and we’re good

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Copy link

codecov bot commented Jun 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.45%. Comparing base (0fce96c) to head (aa87cd4).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3778   +/-   ##
=======================================
  Coverage   99.45%   99.45%           
=======================================
  Files           3        3           
  Lines         183      183           
=======================================
  Hits          182      182           
  Misses          1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aldy505
Copy link
Collaborator Author

aldy505 commented Jun 24, 2025

@BYK nooo retract your approval. See Slack.

@phacops
Copy link
Contributor

phacops commented Jun 24, 2025

This is the right idea, we'll need those consumers at some point soon (in the next few weeks). We already need the items consumer for logs (it's not GA though).

This PR (getsentry/relay#4843) should address the test failures.

@aldy505
Copy link
Collaborator Author

aldy505 commented Jun 24, 2025

@phacops @Dav1dde this PR includes process-spans sentry consumer. Do you want me to remove it?

@phacops
Copy link
Contributor

phacops commented Jun 24, 2025

Not if the release is mid July, we might want to add the full set of items and buffer consumers and remove spans specific consumers.

@aldy505 aldy505 changed the title feat: run snuba-items consumer [MERGE AFTER 15 JULY] feat: run snuba-items consumer Jun 25, 2025
@aldy505 aldy505 changed the title [MERGE AFTER 15 JULY] feat: run snuba-items consumer feat: run snuba-items consumer Jun 25, 2025
@aldy505 aldy505 requested a review from Zylphrex June 25, 2025 02:42
@aldy505
Copy link
Collaborator Author

aldy505 commented Jun 25, 2025

@jan-auer Pierre said that we need to include the sentry consumer that runs the buffer, I don't know what's that referring to.

@aldy505
Copy link
Collaborator Author

aldy505 commented Jun 25, 2025

Found it.

@aldy505 aldy505 requested review from jan-auer and removed request for phacops June 25, 2025 07:14
@aldy505
Copy link
Collaborator Author

aldy505 commented Jun 25, 2025

Pierre will be on PTO, hence I removed his review.

@aldy505 aldy505 changed the title feat: run snuba-items consumer feat: run EAP-related containers Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants