Lint source code

Author: repejota

Makefile

@@ -58,6 +58,7 @@ benchmark:		## Execute package benchmarks
 
 deps:			## Install build dependencies
 	go get -u
+	go mod tidy -v
 	go mod download
 	go mod verify
 
@@ -72,6 +73,12 @@ clean:			## Delete generated development environment
 	rm -rf ${BINARY}-*-*.zip
 	rm -rf coverage-all.out
 
+# Lint
+
+.PHONY: lint
+lint:			## Lint source code
+	./lint.bash
+
 # Docs
 
 godoc-serve:		## Serve documentation (godoc format) for this package at port HTTP 9090

dag.go

@@ -63,7 +63,7 @@ func (d *DAG) DeleteVertex(vertex *Vertex) error {
 			existsVertex = true
 		}
 	}
-	if existsVertex == false {
+	if !existsVertex {
 		return fmt.Errorf("Vertex with ID %v not found", vertex.ID)
 	}
 
@@ -89,10 +89,10 @@ func (d *DAG) AddEdge(tailVertex *Vertex, headVertex *Vertex) error {
 			headExists = true
 		}
 	}
-	if tailExists == false {
+	if !tailExists {
 		return fmt.Errorf("Vertex with ID %v not found", tailVertex.ID)
 	}
-	if headExists == false {
+	if !headExists {
 		return fmt.Errorf("Vertex with ID %v not found", headVertex.ID)
 	}
 
@@ -170,7 +170,7 @@ func (d *DAG) Successors(vertex *Vertex) ([]*Vertex, error) {
 	var successors []*Vertex
 
 	_, found := d.Vertices.Get(vertex.ID)
-	if found != true {
+	if !found {
 		return successors, fmt.Errorf("vertex %s not found in the graph", vertex.ID)
 	}
 
@@ -186,7 +186,7 @@ func (d *DAG) Predecessors(vertex *Vertex) ([]*Vertex, error) {
 	var predecessors []*Vertex
 
 	_, found := d.Vertices.Get(vertex.ID)
-	if found != true {
+	if !found {
 		return predecessors, fmt.Errorf("vertex %s not found in the graph", vertex.ID)
 	}
 
@@ -200,13 +200,11 @@ func (d *DAG) Predecessors(vertex *Vertex) ([]*Vertex, error) {
 // String implements stringer interface and prints an string representation
 // of this instance.
 func (d *DAG) String() string {
-	var result string
-	result = fmt.Sprintf("DAG Vertices: %d - Edges: %d\n", d.Order(), d.Size())
-	result = result + fmt.Sprintf("Vertices:\n")
+	result := fmt.Sprintf("DAG Vertices: %d - Edges: %d\n", d.Order(), d.Size())
+	result += fmt.Sprintf("Vertices:\n")
 	for _, vertex := range d.Vertices.Values() {
 		vertex = vertex.(*Vertex)
-
-		result = result + fmt.Sprintf("%s", vertex)
+		result += fmt.Sprintf("%s", vertex)
 	}
 
 	return result

go.mod

@@ -1,6 +1,6 @@
 module github.com/goombaio/dag
 
 require (
-	github.com/goombaio/orderedmap v0.0.0-20180913224324-4f3ec14b67ee
-	github.com/goombaio/orderedset v0.0.0-20180913224306-7932f51baeff
+	github.com/goombaio/orderedmap v0.0.0-20180914055104-17aec6e5c534
+	github.com/goombaio/orderedset v0.0.0-20180914055012-52cd141747e3
 )

go.sum

@@ -1,9 +1,5 @@
-github.com/goombaio/orderedmap v0.0.0-20180909122926-bcb33a330965 h1:B5j5Xc220Wek927iQU58XPVBgqffiDYJ/WbCT+xSniI=
-github.com/goombaio/orderedmap v0.0.0-20180909122926-bcb33a330965/go.mod h1:YKu81H3RSd1cFh0d7NhvUoTtUC9IY/vBX0WUQb1/o4Y=
 github.com/goombaio/orderedmap v0.0.0-20180909154953-8a7ec76cbbe3/go.mod h1:YKu81H3RSd1cFh0d7NhvUoTtUC9IY/vBX0WUQb1/o4Y=
-github.com/goombaio/orderedmap v0.0.0-20180913224324-4f3ec14b67ee h1:kJuaDxXc3p+b8zwdo6DWLx7Rb68+6nsJ1B1kQsng9oc=
-github.com/goombaio/orderedmap v0.0.0-20180913224324-4f3ec14b67ee/go.mod h1:YKu81H3RSd1cFh0d7NhvUoTtUC9IY/vBX0WUQb1/o4Y=
-github.com/goombaio/orderedset v0.0.0-20180909125127-122dc7308614 h1:xAdni1zGwgnswG1Ffz3aLRSGVgK36cwHGxmhDtZg9vU=
-github.com/goombaio/orderedset v0.0.0-20180909125127-122dc7308614/go.mod h1:W4Pn44eHLAcM1jflSDi6Uef2+y9spkuhg7OnM1xjB0A=
-github.com/goombaio/orderedset v0.0.0-20180913224306-7932f51baeff h1:2WMDnw2xDxCvQaxt44zr9WknHoPjO9U5L3oB/AYm7x4=
-github.com/goombaio/orderedset v0.0.0-20180913224306-7932f51baeff/go.mod h1:R1TTMcaEzt9BEIx7zMybVI+SYaxlsOcbUKtxBKcus10=
+github.com/goombaio/orderedmap v0.0.0-20180914055104-17aec6e5c534 h1:900x/Rd8UHHF2J1Ca2tIspnjiqSCa4kCKIkRM502Vc4=
+github.com/goombaio/orderedmap v0.0.0-20180914055104-17aec6e5c534/go.mod h1:YKu81H3RSd1cFh0d7NhvUoTtUC9IY/vBX0WUQb1/o4Y=
+github.com/goombaio/orderedset v0.0.0-20180914055012-52cd141747e3 h1:yQVltnuJPTyUTQ6wYYN0SmMDLvds76oVQZu1KRYFMu4=
+github.com/goombaio/orderedset v0.0.0-20180914055012-52cd141747e3/go.mod h1:R1TTMcaEzt9BEIx7zMybVI+SYaxlsOcbUKtxBKcus10=

lint.bash

@@ -0,0 +1,26 @@
+#!/usr/bin/env bash
+
+set -o errexit
+set -o nounset
+set -o pipefail
+
+if [ ! $(command -v gometalinter) ]
+then
+	go get github.com/alecthomas/gometalinter
+	gometalinter --update --install
+fi
+
+time gometalinter \
+	--exclude='error return value not checked.*(Close|Log|Print).*\(errcheck\)$' \
+	--exclude='.*_test\.go:.*error return value not checked.*\(errcheck\)$' \
+	--exclude='/thrift/' \
+	--exclude='/pb/' \
+	--exclude='no args in Log call \(vet\)' \
+	--disable=dupl \
+	--disable=aligncheck \
+	--disable=gotype \
+	--cyclo-over=20 \
+	--tests \
+	--concurrency=2 \
+	--deadline=300s \
+	./...