Fix UDP multicast interface on MacOS #1940
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dennis-Johnson
changed the title
|
Also, the example provided in your docs fails with line 320, in _create_socket
raise can.CanInitializationError(
can.exceptions.CanInitializationError: could not create or configure socket |
zariiii9003
reviewed
May 31, 2025
can/interfaces/udp_multicast/bus.py
Outdated
| @@ -21,6 +22,8 @@ | |||
| ioctl_supported = False | |||
| pass | |||
|
|
|||
| # All ioctls aren't supported on MacOS. | |||
| is_macos = platform.system() == "Darwin" | |||
There was a problem hiding this comment.
I don't like having two flags ioctl_supported and is_macos for the same purpose. Maybe we could import ioctl on Linux only?
There was a problem hiding this comment.
Sorry for the delay. Changed the flag to a single is_linux instead of the previous two.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This fixes #1760 to allow usage of the UDP Multicast backend on MacOS.
The ioctl check before timestamping in recv was only partially fixed for Windows on main, but MacOS still doesn't support this ioctl.
The second change is adding the SO_REUSEPORT option.