Skip to content

Improve GitHub Action security #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 2, 2025
Merged

Improve GitHub Action security #345

merged 2 commits into from
Jul 2, 2025

Conversation

danyeaw
Copy link
Collaborator

@danyeaw danyeaw commented May 8, 2025

This PR implements two best practices:

  1. Pin GitHub Actions to their full commit SHA version
  2. Reduce GITHUB_TOKEN scope to repository read by default. Permissions can then be increased only when needed.

@danyeaw danyeaw requested a review from RRosio June 3, 2025 15:17
RRosio
RRosio approved these changes Jul 2, 2025
View reviewed changes
Copy link
Collaborator

@RRosio RRosio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Dan, and sorry I missed this PR earlier. This is a great security update!

@RRosio RRosio merged commit 7926a9a into jupyter:main Jul 2, 2025
39 of 40 checks passed
@danyeaw danyeaw deleted the ci-pin branch July 3, 2025 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RRosio RRosio

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danyeaw @RRosio