Generate LSP request IDs atomically

[jakebailey]

WARNING: DATA RACE
Read at 0x00c000232a50 by goroutine 1006:
  github.com/microsoft/typescript-go/internal/lsp.(*Server).sendRequest()
      /home/jabaile/work/TypeScript-go/internal/lsp/server.go:402 +0x91
  github.com/microsoft/typescript-go/internal/lsp.(*Server).WatchFiles()
      /home/jabaile/work/TypeScript-go/internal/lsp/server.go:198 +0x36c
  github.com/microsoft/typescript-go/internal/project.(*watchedFiles[go.shape.[]string]).update()
      /home/jabaile/work/TypeScript-go/internal/project/watch.go:85 +0xbc1
  github.com/microsoft/typescript-go/internal/project.(*ConfigFileRegistry).updateRootFilesWatch()
      /home/jabaile/work/TypeScript-go/internal/project/configfileregistry.go:134 +0x990
  github.com/microsoft/typescript-go/internal/project.(*ConfigFileRegistry).AcquireConfig()
      /home/jabaile/work/TypeScript-go/internal/project/configfileregistry.go:111 +0x5c4
  github.com/microsoft/typescript-go/internal/project.(*Project).GetResolvedProjectReference()
      /home/jabaile/work/TypeScript-go/internal/project/project.go:290 +0x88
  github.com/microsoft/typescript-go/internal/compiler.(*projectReferenceParseTask).start()
      /home/jabaile/work/TypeScript-go/internal/compiler/projectreferenceparsetask.go:19 +0xde
  github.com/microsoft/typescript-go/internal/compiler.(*fileLoaderWorker[go.shape.*github.com/microsoft/typescript-go/internal/compiler.projectReferenceParseTask]).start.func1()
      /home/jabaile/work/TypeScript-go/internal/compiler/fileloadertask.go:35 +0x63
  github.com/microsoft/typescript-go/internal/core.(*parallelWorkGroup).Queue.func1()
      /home/jabaile/work/TypeScript-go/internal/core/workgroup.go:39 +0x8d

Previous write at 0x00c000232a50 by goroutine 1007:
  github.com/microsoft/typescript-go/internal/lsp.(*Server).sendRequest()
      /home/jabaile/work/TypeScript-go/internal/lsp/server.go:402 +0xad
  github.com/microsoft/typescript-go/internal/lsp.(*Server).WatchFiles()
      /home/jabaile/work/TypeScript-go/internal/lsp/server.go:198 +0x36c
  github.com/microsoft/typescript-go/internal/project.(*watchedFiles[go.shape.[]string]).update()
      /home/jabaile/work/TypeScript-go/internal/project/watch.go:85 +0xbc1
  github.com/microsoft/typescript-go/internal/project.(*ConfigFileRegistry).updateRootFilesWatch()
      /home/jabaile/work/TypeScript-go/internal/project/configfileregistry.go:134 +0x990
  github.com/microsoft/typescript-go/internal/project.(*ConfigFileRegistry).AcquireConfig()
      /home/jabaile/work/TypeScript-go/internal/project/configfileregistry.go:111 +0x5c4
  github.com/microsoft/typescript-go/internal/project.(*Project).GetResolvedProjectReference()
      /home/jabaile/work/TypeScript-go/internal/project/project.go:290 +0x88
  github.com/microsoft/typescript-go/internal/compiler.(*projectReferenceParseTask).start()
      /home/jabaile/work/TypeScript-go/internal/compiler/projectreferenceparsetask.go:19 +0xde
  github.com/microsoft/typescript-go/internal/compiler.(*fileLoaderWorker[go.shape.*github.com/microsoft/typescript-go/internal/compiler.projectReferenceParseTask]).start.func1()
      /home/jabaile/work/TypeScript-go/internal/compiler/fileloadertask.go:35 +0x63
  github.com/microsoft/typescript-go/internal/core.(*parallelWorkGroup).Queue.func1()
      /home/jabaile/work/TypeScript-go/internal/core/workgroup.go:39 +0x8d

[Copilot]

Pull Request Overview

This PR fixes a data race on the LSP server’s request ID counter by switching to atomic increments.

• Import sync/atomic and change clientSeq from int32 to atomic.Int32
• Update sendRequest to use clientSeq.Add(1) when generating each new request ID

Comments suppressed due to low confidence (1)

internal/lsp/server.go:403

• Add a concurrent test for sendRequest to ensure that request IDs remain unique and no data races occur when multiple goroutines generate IDs simultaneously.

id := lsproto.NewIDString(fmt.Sprintf("ts%d", s.clientSeq.Add(1)))