Fix hardcoded /tmp paths for cross-platform compatibility using osTempDir #606
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mpDir Replaced all instances of hardcoded "/tmp/..." paths with filepath.Join(os.TempDir(), ...) to ensure compatibility on Windows systems. This aligns with Go's cross-platform best practices and addresses issue mmcgrana#562. Also added clarifying comments in examples where code was unreachable due to panic.
eliben
reviewed
May 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced all instances of hardcoded "/tmp/..." paths with
filepath.Join(os.TempDir(), ...)to ensure compatibility on Windows systems. This aligns with Go's cross-platform best practices and addresses issue #562.Also added clarifying comments in examples where code was unreachable due to panic.