Skip to content

impr(quotes): add english quotes (@akifGuy) #6580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

akifGuy
Copy link

@akifGuy akifGuy commented May 20, 2025

Description

I added a new quote to english.json from "A Minecraft Movie" with the ID 7647

Checks

  • Adding quotes?

    • Make sure to include translations for the quotes in the description (or another comment) so we can verify their content.
  • Adding a language?

    • Make sure to follow the languages documentation
    • Add language to packages/contracts/src/schemas/languages.ts
    • Add language to exactly one group in frontend/src/ts/constants/languages.ts
    • Add language json file to frontend/static/languages
  • Adding a theme?

    • Make sure to follow the themes documentation
    • Add theme to packages/contracts/src/schemas/themes.ts
    • Add theme to frontend/src/ts/constants/themes.ts
    • Add theme css file to frontend/static/themes
  • Adding a layout?

    • Make sure to follow the layouts documentation
    • Add layout to packages/contracts/src/schemas/layouts.ts
    • Add layout json file to frontend/static/layouts
    • Also please add a screenshot of the theme, it would be extra awesome if you do so!
  • Check if any open issues are related to this PR; if so, be sure to tag them below.

  • Make sure the PR title follows the Conventional Commits standard. (https://www.conventionalcommits.org for more info)

  • Make sure to include your GitHub username prefixed with @ inside parentheses at the end of the PR title.

Closes #

@monkeytypegeorge monkeytypegeorge added frontend User interface or web stuff assets Languages, themes, layouts, etc. labels May 20, 2025
@Miodec
Copy link
Member

Miodec commented May 26, 2025

Looks like you've modified the entire file. Please revert those changes so that only the quote is added.

@Miodec Miodec added the waiting for update Pull requests or issues that require changes/comments before continuing label May 26, 2025
@Miodec
Copy link
Member

Miodec commented Jun 16, 2025

Closing due to inactivity.

@Miodec Miodec closed this Jun 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assets Languages, themes, layouts, etc. frontend User interface or web stuff waiting for update Pull requests or issues that require changes/comments before continuing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants