Skip to content

impr(quotes): update gladiator quote (@acdpsn) #6626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 16, 2025

Conversation

acdpsn
Copy link
Contributor

@acdpsn acdpsn commented Jun 7, 2025

Description

Update a Gladiator quote to fix a typo and fix the title to properly reference the movie name.

Checks

  • Adding quotes?
    • Make sure to include translations for the quotes in the description (or another comment) so we can verify their content.
  • Adding a language?
    • Make sure to follow the languages documentation
    • Add language to packages/contracts/src/schemas/languages.ts
    • Add language to exactly one group in frontend/src/ts/constants/languages.ts
    • Add language json file to frontend/static/languages
  • Adding a theme?
    • Make sure to follow the themes documentation
    • Add theme to packages/contracts/src/schemas/themes.ts
    • Add theme to frontend/src/ts/constants/themes.ts
    • Add theme css file to frontend/static/themes
    • Also please add a screenshot of the theme, it would be extra awesome if you do so!
  • Adding a layout?
    • Make sure to follow the layouts documentation
    • Add layout to packages/contracts/src/schemas/layouts.ts
    • Add layout json file to frontend/static/layouts
  • Check if any open issues are related to this PR; if so, be sure to tag them below.
  • Make sure the PR title follows the Conventional Commits standard. (https://www.conventionalcommits.org for more info)
  • Make sure to include your GitHub username prefixed with @ inside parentheses at the end of the PR title.

Closes #

@monkeytypegeorge monkeytypegeorge added frontend User interface or web stuff assets Languages, themes, layouts, etc. labels Jun 7, 2025
Copy link
Member

@Miodec Miodec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@Miodec Miodec merged commit ebfa8be into monkeytypegame:master Jun 16, 2025
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assets Languages, themes, layouts, etc. frontend User interface or web stuff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants