Skip to content

refactor(hints): improve readability of hints functions (@NadAlaba) #6629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jul 9, 2025

Conversation

NadAlaba
Copy link
Contributor

@NadAlaba NadAlaba commented Jun 9, 2025

  • Refactoring joinOverlappingHints() solves the issue of hints joining when they correspond to letters of different lines, which was one of the issues #6636 was supposed to solve.
  • Also add a utility that debounces/locks async functions.

@monkeytypegeorge monkeytypegeorge added the frontend User interface or web stuff label Jun 9, 2025
@NadAlaba NadAlaba marked this pull request as draft June 10, 2025 16:38
@NadAlaba NadAlaba force-pushed the refactor-hints-functions branch from cec0a09 to 5d74fc1 Compare June 11, 2025 16:36
@NadAlaba NadAlaba marked this pull request as ready for review June 11, 2025 16:43
@github-actions github-actions bot added the waiting for review Pull requests that require a review before continuing label Jun 11, 2025
@NadAlaba NadAlaba force-pushed the refactor-hints-functions branch from 5d74fc1 to 4059ea1 Compare June 12, 2025 18:29
@NadAlaba NadAlaba changed the title refactor(hints): improve readability of joinOverlappingHints() (@NadAlaba) refactor(hints): improve readability of hints functions (@NadAlaba) Jun 12, 2025
@NadAlaba NadAlaba force-pushed the refactor-hints-functions branch from 4059ea1 to 074c956 Compare June 16, 2025 17:31
@NadAlaba NadAlaba force-pushed the refactor-hints-functions branch from 074c956 to 8b0a503 Compare June 19, 2025 16:47
@NadAlaba NadAlaba force-pushed the refactor-hints-functions branch from 8b0a503 to 6c1a4f5 Compare June 19, 2025 18:10
@github-actions github-actions bot removed the waiting for review Pull requests that require a review before continuing label Jun 25, 2025
@Miodec Miodec added the waiting for update Pull requests or issues that require changes/comments before continuing label Jun 25, 2025
@github-actions github-actions bot removed the waiting for update Pull requests or issues that require changes/comments before continuing label Jun 30, 2025
@Miodec Miodec added the waiting for update Pull requests or issues that require changes/comments before continuing label Jul 9, 2025
@github-actions github-actions bot removed the waiting for update Pull requests or issues that require changes/comments before continuing label Jul 9, 2025
Copy link
Member

@Miodec Miodec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@Miodec Miodec merged commit 5243d14 into monkeytypegame:master Jul 9, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend User interface or web stuff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants