Skip to content

fix(wordsInput): clamp #wordsInput from the left to #wordsWrapper (@NadAlaba) #6637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 25, 2025

Conversation

NadAlaba
Copy link
Contributor

Description

In RTL tape mode (which will be a reality after #5748), if a long word is wider than the #wordsWrapper, then #wordsInput may overflow to the left causing a horizontal scroll to keep it in view. This PR prevents its left edge from overflowing the #wordsWrapper.

@monkeytypegeorge monkeytypegeorge added the frontend User interface or web stuff label Jun 12, 2025
@Miodec Miodec added the on hold Pull request on hold label Jun 16, 2025
@Miodec Miodec added waiting for review Pull requests that require a review before continuing and removed on hold Pull request on hold labels Jun 25, 2025
Copy link
Member

@Miodec Miodec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@Miodec Miodec merged commit 217981e into monkeytypegame:master Jun 25, 2025
12 checks passed
@github-actions github-actions bot removed the waiting for review Pull requests that require a review before continuing label Jun 25, 2025
@NadAlaba NadAlaba deleted the clamp-wordsInput branch June 30, 2025 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend User interface or web stuff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants