clear a few TODOs

mtanzim · mtanzim · commit ed45d33c2fa4 · 2020-12-30T16:52:27.000-05:00
diff --git a/bookstore-server/service/checkout.go b/bookstore-server/service/checkout.go
@@ -67,7 +67,6 @@ func (s CheckoutService) stageStock(items []dto.CartItem, done chan bool) {
 	}
 }
 
-// TODO: fire off shipment message
 func (s CheckoutService) requestCartShipment(cart *dto.Cart, id primitive.ObjectID) {
 
 	cartShipment := dto.CartShipment{
diff --git a/payment/service/payment.go b/payment/service/payment.go
@@ -58,7 +58,6 @@ func (s PaymentService) processPayment(paymentRequest *dto.CartPayment) {
 	}
 }
 
-// TODO: move this to common?
 func (s PaymentService) sendMessageToProducer(topic *string, msg []byte) {
 
 	err := s.producer.Produce(&kafka.Message{
diff --git a/warehouse-server/service/shipment.go b/warehouse-server/service/shipment.go
@@ -108,7 +108,6 @@ func (s ShipmentService) persist(shipmentRequest dto.CartWarehouse) {
 		if err == mongo.ErrNoDocuments {
 			insertRes, insertErr := s.collection.InsertOne(ctx, shipmentRequest)
 			if insertErr != nil {
-				// TODO: ignore failed insert on duplicate?
 				log.Println(err)
 			}
 			log.Println("Inserted shipment ", insertRes.InsertedID)

Original file line number	Diff line number	Diff line change
`@@ -67,7 +67,6 @@ func (s CheckoutService) stageStock(items []dto.CartItem, done chan bool) {`
`67`	`67`	`}`
`68`	`68`	`}`
`69`	`69`
`70`		`-// TODO: fire off shipment message`
`71`	`70`	`func (s CheckoutService) requestCartShipment(cart *dto.Cart, id primitive.ObjectID) {`
`72`	`71`
`73`	`72`	`cartShipment := dto.CartShipment{`
Original file line number	Diff line number	Diff line change
`@@ -58,7 +58,6 @@ func (s PaymentService) processPayment(paymentRequest *dto.CartPayment) {`
`58`	`58`	`}`
`59`	`59`	`}`
`60`	`60`
`61`		`-// TODO: move this to common?`
`62`	`61`	`func (s PaymentService) sendMessageToProducer(topic *string, msg []byte) {`
`63`	`62`
`64`	`63`	`err := s.producer.Produce(&kafka.Message{`
Original file line number	Diff line number	Diff line change
`@@ -108,7 +108,6 @@ func (s ShipmentService) persist(shipmentRequest dto.CartWarehouse) {`
`108`	`108`	`if err == mongo.ErrNoDocuments {`
`109`	`109`	`insertRes, insertErr := s.collection.InsertOne(ctx, shipmentRequest)`
`110`	`110`	`if insertErr != nil {`
`111`		`- // TODO: ignore failed insert on duplicate?`
`112`	`111`	`log.Println(err)`
`113`	`112`	`}`
`114`	`113`	`log.Println("Inserted shipment ", insertRes.InsertedID)`