Skip to content

Commit 21c2aeb

Browse files
committed
Merge branch 'eonasdan v3.1.1'
Majer changes: - upgraded to the latest submodule version (bootstrap-datetimepicker v3.1.1) - compatible with the latest momentjs library (version 2.8.1) - included the simpleform & momemtjy dependency in gem's Gemfile
2 parents ff3700d + 2924bf0 commit 21c2aeb

File tree

4 files changed

+13
-15
lines changed

4 files changed

+13
-15
lines changed

Gemfile

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,3 +2,5 @@ source 'https://rubygems.org'
22

33
# Specify your gem's dependencies in datetimepicker-rails.gemspec
44
gemspec
5+
gem 'simple_form', '>= 3.1.0.rc1'
6+
gem 'momentjs-rails', '>= 2.8.1'

README.md

Lines changed: 9 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ This gem packages the bootstrap-datetimepicker for Rails asset pipeline, and cre
1818

1919
### Compatibility
2020

21-
Master from v3.0.2+ and eonasdan branch: Bootstrap 3+, Rails 4+ and SimpleForm 3.1.RC1+ (using https://github.com/eonasdan/bootstrap-datetimepicker.git as submodule, well maintained repo). Any further development will be made on these branches.
21+
Master & eonasdan branches, tags v3.0.2+: Bootstrap 3+, Rails 4+ and SimpleForm 3.1.RC1+ (using https://github.com/eonasdan/bootstrap-datetimepicker.git as submodule, well maintained repo). Any further development will be made on these branches.
2222

2323
Tag v3.0.1 and tarruda branch: Bootstrap 3+, Rails 4+ and SimpleForm 3.1.RC1+ (using an upgraded version of https://github.com/tarruda/bootstrap-datetimepicker.git as inline code, not maintained). No further development, only bug fix for fatal issues on this branch.
2424

@@ -27,12 +27,9 @@ Tag v1.0.0: Rails 3.2, Bootstrap 2.3.2 & SimpleForm >= 2.0.4 - No further develo
2727

2828
### Dependency
2929

30-
The current versions (v3.0.2+) has a dependency on the moment.js javascript library (for details refer to: http://momentjs.com/).
31-
The gem **does not install this library** out of the box, so **you must look after that**. The reason for not included in this gem the
32-
installation of moment.js is if you use any package that includes this library (for instance fullcalendar) it would be double installed.
33-
34-
It is very easy to install this library by using the https://github.com/derekprior/momentjs-rails gem.
30+
Versions v3.1.1+ has a dependency on the moment.js version 2.8.1 javascript library (for details refer to: http://momentjs.com/) and the gem includes the dependency reference in its Gemfile (gem 'momentjs-rails', '>= 2.8.1', :github => 'derekprior/momentjs-rails').
3531

32+
Versions v3.0.2 & v3.0.3 has a dependency on the moment.js version v2.7, but the gem **have not installed this library** out of the box, so **you have to look after that**. Put "gem 'momentjs-rails', '2.7', :github => 'derekprior/momentjs-rails'" to your project Gemfile to install it.
3633

3734
### Credits and references
3835

@@ -45,7 +42,7 @@ The project home page: https://github.com/zpaulovics/datetimepicker-rails.git
4542

4643
According your needs, add one of the lines below to your application's Gemfile:
4744

48-
gem 'datetimepicker-rails', '>= 3.0.0', :git => 'git://github.com/zpaulovics/datetimepicker-rails.git', \
45+
gem 'datetimepicker-rails', :git => 'git://github.com/zpaulovics/datetimepicker-rails.git', \
4946
:branch => 'master', :submodules => true
5047

5148
gem 'datetimepicker-rails', '>= 3.0.0', :git => 'git://github.com/zpaulovics/datetimepicker-rails.git', :branch => 'tarruda'
@@ -70,17 +67,14 @@ or
7067

7168
Add this line to app/assets/javascripts/application.js
7269

73-
``` javascript
74-
//= require bootstrap-datetimepicker
75-
```
76-
77-
You can fine tune the included files to suit your needs.
78-
7970
From version 3.0.2+:
8071

8172
```javascript
73+
//= require moment
8274
//= require bootstrap-datetimepicker
8375
//= require pickers
76+
77+
// You may include any languages (optional)
8478
//= require locales/bootstrap-datetimepicker.hu
8579
```
8680

@@ -89,6 +83,8 @@ Earlier version:
8983
```javascript
9084
//= require bootstrap-datetimepicker/core
9185
//= require bootstrap-datetimepicker/pickers
86+
87+
// You may include any languages (optional)
9288
//= require bootstrap-datetimepicker/locales/bootstrap-datetimepicker.hu
9389
```
9490

bootstrap-datetimepicker

Submodule bootstrap-datetimepicker updated from ac4ba17 to 2c22d7d

lib/datetimepicker-rails/version.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
module Datetimepicker
22
module Rails
3-
VERSION = "3.0.3"
3+
VERSION = "3.1.1"
44
end
55
end

0 commit comments

Comments
 (0)