fs: fix TypeError in glob when directory access is denied #58674

Sylphy-0xd3ac · 2025-06-11T11:02:45Z

When a directory cannot be read due to permission issues, the async version of fs.glob() returns null from readdir(), while the sync version returns an empty array. This causes a TypeError when trying to access the 'length' property of null.

Fix by making the async readdir() method return an empty array on error, consistent with the sync version behavior.

Fixes: #58670
Fixes: #58276

juanarbol · 2025-06-11T19:58:47Z

This is nice! Thanks! Would you mind adding a test case? Just make sure that it will never return null

Sylphy-0xd3ac · 2025-06-12T13:06:00Z

@juanarbol Done. Added test case

juanarbol

LGTM! Thanks!

nodejs-github-bot · 2025-06-13T17:02:08Z

CI: https://ci.nodejs.org/job/node-test-pull-request/67430/

codecov · 2025-06-13T17:48:31Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.99%. Comparing base (5ebfb99) to head (59b82bb).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #58674      +/-   ##
==========================================
+ Coverage   89.97%   89.99%   +0.02%     
==========================================
  Files         649      649              
  Lines      192194   192194              
  Branches    37678    37683       +5     
==========================================
+ Hits       172918   172958      +40     
+ Misses      11873    11836      -37     
+ Partials     7403     7400       -3

Files with missing lines	Coverage Δ
lib/internal/fs/glob.js	`91.98% <100.00%> (ø)`

... and 40 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sylphy-0xd3ac · 2025-06-15T23:39:29Z

Delete the test-fs-glob-readdir-error-handling.mjs file as its functionality is now covered by the test-fs-glob.mjs

test/parallel/test-fs-glob.mjs

nodejs-github-bot · 2025-06-16T14:36:30Z

CI: https://ci.nodejs.org/job/node-test-pull-request/67483/

Sylphy-0xd3ac · 2025-06-24T12:34:04Z

Add PR-URL and Reviewed-By fields to the commit message

Ethan-Arrowood · 2025-06-26T15:24:46Z

I think you need to stop force-pushing so it can land. Another contributor can correct me if I'm wrong though

Sylphy-0xd3ac · 2025-06-27T08:24:27Z

Sorry for the force-push. Could you please help re-approve this PR so it can land? Thank you

github-actions · 2025-07-16T13:25:39Z

Failed to start CI

   ⚠  Commits were pushed since the last approving review:
   ⚠  - fs: fix glob TypeError on restricted dirs
   ⚠  - Merge branch 'nodejs:main' into main
   ✘  Refusing to run CI on potentially unsafe PR

https://github.com/nodejs/node/actions/runs/16320742288

Sylphy-0xd3ac · 2025-07-17T07:20:05Z

It seems like the CI did not run because new commits were pushed after the last approving review?

nodejs-github-bot · 2025-07-17T20:54:44Z

CI: https://ci.nodejs.org/job/node-test-pull-request/67988/

Sylphy-0xd3ac · 2025-07-19T00:32:32Z

The last CI failures ultimately point to node-test-commit-arm-debug node-test-binary-windows-js-suites The first one had network issues when cloning the git repository, the second one had ECONNRESET error during inspector testing. This might be coincidental since there have never been problems before. PR #59091 explains the why Windows CI failure in this PR.

nodejs-github-bot · 2025-07-21T07:13:00Z

CI: https://ci.nodejs.org/job/node-test-pull-request/68050/

nodejs-github-bot · 2025-07-21T09:44:21Z

CI: https://ci.nodejs.org/job/node-test-pull-request/68052/

Sylphy-0xd3ac · 2025-07-22T14:08:41Z

Another CI node-test-commit-aix failure:
ENOSPC: System limit for number of file watchers reached
Looks like a coincidental issue again

RafaelGSS · 2025-07-31T21:06:06Z

@Sylphy-0xd3ac It seems your first commit doesn't have the correct author. Can you squash all your 10 commits and make sure to --reset-author?

When a directory cannot be read due to permission issues, the async version of fs.glob() returns null from readdir(), while the sync version returns an empty array. This causes a TypeError when trying to access the 'length' property of null. PR-URL: #58674 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ethan-Arrowood <ethan@arrowood.dev> Reviewed-By: Juan José <soyjuanarbol@gmail.com>

Sylphy-0xd3ac · 2025-08-01T00:20:01Z

@RafaelGSS I did it, is that it?

RafaelGSS · 2025-08-01T12:56:57Z

@RafaelGSS I did it, is that it?

Yes! Once CI is green (again), PR will be merged.

nodejs-github-bot · 2025-08-01T13:13:05Z

CI: https://ci.nodejs.org/job/node-test-pull-request/68349/ 💛

When a directory cannot be read due to permission issues, the async version of fs.glob() returns null from readdir(), while the sync version returns an empty array. This causes a TypeError when trying to access the 'length' property of null. PR-URL: #58674 Fixes: #58670 Fixes: #58276 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ethan-Arrowood <ethan@arrowood.dev> Reviewed-By: Juan José <soyjuanarbol@gmail.com>

jasnell · 2025-08-01T14:26:20Z

Landed in 5794e64

When a directory cannot be read due to permission issues, the async version of fs.glob() returns null from readdir(), while the sync version returns an empty array. This causes a TypeError when trying to access the 'length' property of null. PR-URL: nodejs#58674 Fixes: nodejs#58670 Fixes: nodejs#58276 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ethan-Arrowood <ethan@arrowood.dev> Reviewed-By: Juan José <soyjuanarbol@gmail.com>

nodejs-github-bot added fs needs-ci labels Jun 11, 2025

Ethan-Arrowood approved these changes Jun 11, 2025

View reviewed changes

jasnell approved these changes Jun 12, 2025

View reviewed changes

juanarbol approved these changes Jun 13, 2025

View reviewed changes

juanarbol added the request-ci label Jun 13, 2025

github-actions bot removed the request-ci label Jun 13, 2025

Sylphy-0xd3ac force-pushed the main branch 2 times, most recently from 6b33002 to 7ae4597 Compare June 14, 2025 08:44

Ethan-Arrowood reviewed Jun 16, 2025

View reviewed changes

test/parallel/test-fs-glob.mjs Show resolved Hide resolved

Ethan-Arrowood approved these changes Jun 16, 2025

View reviewed changes

Ethan-Arrowood added the request-ci label Jun 16, 2025

github-actions bot removed the request-ci label Jun 16, 2025

Ethan-Arrowood approved these changes Jun 17, 2025

View reviewed changes

Ethan-Arrowood approved these changes Jun 20, 2025

View reviewed changes

Sylphy-0xd3ac force-pushed the main branch 3 times, most recently from 8c18cc5 to 0a4f0f9 Compare June 24, 2025 10:55

Sylphy-0xd3ac force-pushed the main branch 3 times, most recently from f1789b7 to a5fdb0f Compare June 25, 2025 23:48

Ethan-Arrowood approved these changes Jul 17, 2025

View reviewed changes

Ethan-Arrowood added request-ci and removed request-ci-failed labels Jul 17, 2025

github-actions bot removed the request-ci label Jul 17, 2025

StefanStojanovic added the request-ci label Jul 21, 2025

github-actions bot removed the request-ci label Jul 21, 2025

RafaelGSS added request-ci author ready and removed author ready request-ci labels Jul 31, 2025

Sylphy-0xd3ac force-pushed the main branch from 6a729ab to 59b82bb Compare August 1, 2025 00:09

RafaelGSS added the request-ci label Aug 1, 2025

github-actions bot removed the request-ci label Aug 1, 2025

jasnell approved these changes Aug 1, 2025

View reviewed changes

jasnell closed this Aug 1, 2025

fs: fix TypeError in glob when directory access is denied #58674

fs: fix TypeError in glob when directory access is denied #58674

Conversation

Sylphy-0xd3ac commented Jun 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

juanarbol commented Jun 11, 2025

Uh oh!

Sylphy-0xd3ac commented Jun 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

juanarbol left a comment

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Jun 13, 2025

Uh oh!

codecov bot commented Jun 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Sylphy-0xd3ac commented Jun 15, 2025

Uh oh!

Uh oh!

nodejs-github-bot commented Jun 16, 2025

Uh oh!

Sylphy-0xd3ac commented Jun 24, 2025

Uh oh!

Ethan-Arrowood commented Jun 26, 2025

Uh oh!

Sylphy-0xd3ac commented Jun 27, 2025

Uh oh!

github-actions bot commented Jul 16, 2025

Uh oh!

Sylphy-0xd3ac commented Jul 17, 2025

Uh oh!

nodejs-github-bot commented Jul 17, 2025

Uh oh!

Sylphy-0xd3ac commented Jul 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Jul 21, 2025

Uh oh!

nodejs-github-bot commented Jul 21, 2025

Uh oh!

Sylphy-0xd3ac commented Jul 22, 2025

Uh oh!

RafaelGSS commented Jul 31, 2025

Uh oh!

Uh oh!

Sylphy-0xd3ac commented Aug 1, 2025

Uh oh!

RafaelGSS commented Aug 1, 2025

Uh oh!

nodejs-github-bot commented Aug 1, 2025 • edited by jasnell Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

jasnell commented Aug 1, 2025

Uh oh!

Sylphy-0xd3ac commented Jun 11, 2025 •

edited

Loading

Sylphy-0xd3ac commented Jun 12, 2025 •

edited

Loading

codecov bot commented Jun 13, 2025 •

edited

Loading

Sylphy-0xd3ac commented Jul 19, 2025 •

edited

Loading

nodejs-github-bot commented Aug 1, 2025 •

edited by jasnell

Loading