Skip to content

Add missing response properties for EmbedResponse #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 7, 2025
Merged

Add missing response properties for EmbedResponse #215

merged 1 commit into from
Apr 7, 2025

Conversation

pouwerkerk
Copy link
Contributor

@pouwerkerk pouwerkerk commented Apr 6, 2025 •
edited
Loading

After ollama/ollama#5709 (Docs updated in ollama/ollama#6079), requests to the /embed endpoint return "metrics" properties including:

  • total_duration
  • load_duration
  • prompt_eval_count

This PR simply adds them to to the EmbedResponse type for consistency with Ollama's API.

@pouwerkerk pouwerkerk changed the title Add missing response properties Add missing response properties for EmbedResponse Apr 6, 2025
BruceMacD
BruceMacD approved these changes Apr 7, 2025
View reviewed changes
Copy link
Collaborator

@BruceMacD BruceMacD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for keeping this up to date, I missed this one

@BruceMacD BruceMacD merged commit b245585 into ollama:main Apr 7, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BruceMacD BruceMacD BruceMacD approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pouwerkerk @BruceMacD