fix(formatHost): support basic auth in host URL #219
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Description
This pull request adds support for Basic Authentication in the formatHost function by including username and password from the input URL into the formatted result.
📌 Motivation
Ollama does not provide built-in security or authentication mechanisms. To protect access to the service—especially in shared or production environments—many users set up a reverse proxy like Nginx to enforce Basic Authentication.
For example:
With this configuration, requests to Ollama require valid credentials. In order for clients to successfully communicate through the reverse proxy, they must include credentials in the request URL (e.g., http://user:pass@host:port). This PR ensures that such credentials are preserved in the formatted host string, enabling compatibility with secured proxy setups.
✅ Changes
Preserve username and password (if provided) in the output of formatHost.
No impact on behavior for URLs without basic auth.
Maintains removal of trailing slashes and default port logic.
🧪 Example
🧪 Added Tests
Comprehensive test cases have been added for: