Extend (fix) definition of public docs in KG Views #4950
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Extended public document access in Knowledge Graph views to include documents from connector credential pairs with access_type='PUBLIC', fixing an oversight from previous migration (3b25685ff73c).
- Modified
user_owned_and_public_docsCTE inbackend/onyx/db/kg_temp_view.pyto check both document-level (d.is_public) and connector-level (ccp.access_type='PUBLIC') public access - Verified functionality using GitHub docs and explicit email ownership removal tests
- Change aligns with migration history that moved from
is_publictoaccess_typefor access control
1 file reviewed, 1 comment
Edit PR Review Bot Settings | Greptile
| @@ -61,7 +61,7 @@ def create_views( | |||
| INNER JOIN kg_used_docs kud ON kud.kg_used_doc_id = d.id | |||
| WHERE ccp.status != 'DELETING' | |||
| AND ccp.access_type != 'SYNC' | |||
| AND u.email = :user_email | |||
| AND (u.email = :user_email or ccp.access_type::text = 'PUBLIC') | |||
There was a problem hiding this comment.
style: consider using access_type = 'PUBLIC' instead of access_type::text = 'PUBLIC' since access_type is already a text field according to migration 61ff3651add4
There was a problem hiding this comment.
damn impressive greptile
Orbital-Web
approved these changes
Jun 26, 2025
| @@ -61,7 +61,7 @@ def create_views( | |||
| INNER JOIN kg_used_docs kud ON kud.kg_used_doc_id = d.id | |||
| WHERE ccp.status != 'DELETING' | |||
| AND ccp.access_type != 'SYNC' | |||
| AND u.email = :user_email | |||
| AND (u.email = :user_email or ccp.access_type::text = 'PUBLIC') | |||
There was a problem hiding this comment.
damn impressive greptile
Weves
approved these changes
Jun 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We covered only 1/2 of the cases how a document can be public. We also need to allow docs with connector_credential_pair.access_type = "PUBLIC"
Linear: https://linear.app/danswer/issue/DAN-2140/bug-definition-of-public-docs-incomplete-in-kg-views
How Has This Been Tested?
Locally, using Github docs. Also explicitly removed email ownership (for test purposes) to make sure that the docs are allowed because of the connector_credential_pair.access_type = "PUBLIC" condition.
Backporting (check the box to trigger backport action)
Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.