Replace reporting page with stimulus

[oliverguenther]

Ticket

https://community.openproject.org/work_packages/64590

What are you trying to accomplish?

Ensure that reporting page works with turbo by refactoring the previous reporting_page code to a stimulus controller, so that is imported and initialized according to our standards

Merge checklist

• Added/updated tests
• Added/updated documentation in Lookbook (patterns, previews, etc)
• Tested major browsers (Chrome, Firefox, Edge, ...)

[bsatarnejad]

You are attaching many .on('change'), .on('click') handlers without removing them. While it's common in older jQuery systems, it can result in memory leaks if DOM is dynamically re-rendered.
My suggestion is jQuery('.filter_rem').off('click').on('click', ...)
What's your opinion?

[oliverguenther]

I replaced them with stimulus actions. There is a dynamically created element that still has it, but that gets cleared up once the element is destroyed in DOM

[oliverguenther]

Hi @bsatarnejad , I addressed your remarks. Could you take another look? 🙏

[bsatarnejad]

Hi @bsatarnejad , I addressed your remarks. Could you take another look? 🙏

Hi @oliverguenther
Code wise, it is good now 👍
It's working properly now, but Ivana mentioned that

In order to reproduce the problem, add some filters and then go to any other module, then come back to Time and costs page. Result: filters you added are in incorrect order and they don't work (dropdown doesn't open).

I checked it, now filters are in incorrect order, but it works correctly. Is it something that we can handle?

[oliverguenther]

Hi @bsatarnejad , when adding new filters, they get added to the bottom and do not have an explicit sort order. When we load the page, the filters are sorted, so they appear different. That behavior seems okay to me for now.