Skip to content

Enable CI metrics #19303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 30, 2025
Merged

Enable CI metrics #19303

merged 1 commit into from
Jun 30, 2025

Conversation

crohr
Copy link
Member

@crohr crohr commented Jun 24, 2025

We now get runtime metrics and costs directly within the post-step of runs-on/action: https://github.com/opf/openproject/actions/runs/15852822320/job/44690492572?pr=19303#step:31:11

2025-06-24-000050-Enable CI metrics · opfopenproject@1a88e78

@crohr crohr requested a review from cbliard June 24, 2025 14:47
Copy link
Member

@cbliard cbliard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The metrics are gorgeous 👏

Comment on lines 27 to +28
runs-on:
labels:
- runs-on
- runner=32cpu-linux-x64
- family=m7+c7+r7+i7
- ram=128
- run-id=${{ github.run_id }}
labels: "runs-on=${{ github.run_id }}/runner=32cpu-linux-x64/family=m7+c7+r7+i7/ram=128"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit confused when reading the docs https://runs-on.com/configuration/job-labels/#how-it-works

In the docs, it recommends something like

jobs:
  test:
    runs-on: runs-on=${{ github.run_id }}/cpu=4/ram=16/family=m7a+m7i-flex/image=ubuntu22-full-x64

but here, there is an intermediate labels in between:

jobs:
  all:
    runs-on:
      labels: "runs-on=${{ github.run_id }}/runner=32cpu-linux-x64/family=m7+c7+r7+i7/ram=128"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitHub allows both, not sure why but maybe they planned on having more attributes that just labels.

@crohr crohr merged commit 7cbfc92 into dev Jun 30, 2025
9 checks passed
@crohr crohr deleted the feature/ci-metrics branch June 30, 2025 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants