[#64619] Add form configuration tab for work package types #19319
Conversation
shiroginne
requested review from
mereghost and
Kharonus
and removed request for
mereghost
Introduces a new `FormConfigurationTabController`, view, and routes to allow editing and updating form configuration for work package types. Updates the attribute groups transformer and update service to handle attribute group parameters correctly.
Add error message
shiroginne
force-pushed
the
implementation/64619-create-form_configuration_tab_controller
branch
from
9ef83ad to
ff554af
Compare
| <%= render ::Types::EditPageHeaderComponent.new(type: @type, tabs: types_tabs) %> | ||
|
|
||
| <%= | ||
| form_for @type, |
There was a problem hiding this comment.
🟡 did you check if there is any way of embedding that code into a primer form?
There was a problem hiding this comment.
I added primer form helper (just now), but the form itself - attribute groups, no. That would be my next step and question to the primer team, as this attribute group is used in many places in the application.
There was a problem hiding this comment.
@Kharonus I doubt so. The components are pretty resilient when it comes to injecting random html/partials inside them.
| def assign_tab | ||
| params[:tab] = "form_configuration" unless params[:tab] | ||
| end |
There was a problem hiding this comment.
🟢 My PR #19364 has the update to TabsHelper that would handle the params, just in case you want to remove this. ;)
There was a problem hiding this comment.
Let's coordinate merge then 😄
| .select { CustomField.custom_field_attribute? it } | ||
| .map { it.gsub(/^custom_field_/, "").to_i } |
There was a problem hiding this comment.
🟢 Can this be made into a filter_map?
shiroginne
deleted the
implementation/64619-create-form_configuration_tab_controller
branch
Ticket
64619
What are you trying to accomplish?
In order to fix the current issue with Types, new controllers were introduced to cover every tab of the Type model.
Introduces a new
FormConfigurationTabController, view, and routes to allow editing and updating form configuration for work package types.Updates the attribute groups transformer and update service to handle attribute group parameters correctly.
Merge checklist