Skip to content

[prometheus-smartctl-exporter] Allow PodMonitor and PriorityClass configuration #5584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

briend
Copy link
Contributor

@briend briend commented Apr 30, 2025

What this PR does / why we need it

Which issue this PR fixes

Special notes for your reviewer

Checklist

  • DCO signed
  • Chart Version bumped
  • Title of the PR starts with chart name (e.g. [prometheus-couchdb-exporter])

Signed-off-by: Brien Dieterle <briend@terascope.io>
@briend briend requested review from kfox1111 and zeritti as code owners April 30, 2025 00:49
@@ -1,3 +1,4 @@
{{- if .Values.serviceMonitor.enabled }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe make this service.enabled... There could be folks using the service along with a manually installed service monitor or prometheus config.

The rest looks good though. Thanks! :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kfox1111 , I agree. I've added that and leave Service enabled by default just in case.

Copy link

stale bot commented Jun 26, 2025

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants